Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: AtomsWrapper to scope css #14490

Merged
merged 4 commits into from Apr 10, 2024
Merged

chore: AtomsWrapper to scope css #14490

merged 4 commits into from Apr 10, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

What does this PR do?

Chore: scope css of atoms package to avoid our css conflicting with users css

@graphite-app graphite-app bot requested a review from a team April 10, 2024 09:18
Copy link
Contributor

github-actions bot commented Apr 10, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added core area: core, team members only platform Anything related to our platform plan 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Apr 10, 2024
@keithwillcode keithwillcode added the api area: API, enterprise API, access token, OAuth label Apr 10, 2024
@graphite-app graphite-app bot requested a review from a team April 10, 2024 09:18
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 4:05pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 4:05pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 4:05pm
qa ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 4:05pm

Copy link

graphite-app bot commented Apr 10, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 10, 2024

Current Playwright Test Results Summary

✅ 309 Passing - ⚠️ 16 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/10/2024 04:19:59pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: e10d9ef

Started: 04/10/2024 04:14:58pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2Retry 1Initial Attempt
5.70% (17) 17 / 298 runs
failed over last 7 days
23.49% (70) 70 / 298 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2Retry 1Initial Attempt
9.87% (31) 31 / 314 runs
failed over last 7 days
28.66% (90) 90 / 314 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Paid booking should be able to be rescheduled
Retry 2Retry 1Initial Attempt
1.99% (6) 6 / 301 runs
failed over last 7 days
4.65% (14) 14 / 301 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
7.52% (23) 23 / 306 runs
failed over last 7 days
27.78% (85) 85 / 306 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to Org
Retry 1Initial Attempt
0.34% (1) 1 / 294 run
failed over last 7 days
7.48% (22) 22 / 294 runs
flaked over last 7 days
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to a team inside organization
Retry 1Initial Attempt
1.37% (4) 4 / 293 runs
failed over last 7 days
9.90% (29) 29 / 293 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
prefill -- future logged in
Retry 1Initial Attempt
0% (0) 0 / 302 runs
failed over last 7 days
2.98% (9) 9 / 302 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0.33% (1) 1 / 305 run
failed over last 7 days
62.62% (191) 191 / 305 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-168.14% (-190) -190 / 113 runs
failed over last 7 days
168.14% (190) 190 / 113 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-168.14% (-190) -190 / 113 runs
failed over last 7 days
168.14% (190) 190 / 113 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-167.26% (-189) -189 / 113 runs
failed over last 7 days
168.14% (190) 190 / 113 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-169.64% (-190) -190 / 112 runs
failed over last 7 days
169.64% (190) 190 / 112 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-169.64% (-190) -190 / 112 runs
failed over last 7 days
169.64% (190) 190 / 112 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-169.64% (-190) -190 / 112 runs
failed over last 7 days
169.64% (190) 190 / 112 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-169.64% (-190) -190 / 112 runs
failed over last 7 days
169.64% (190) 190 / 112 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.65% (2) 2 / 308 runs
failed over last 7 days
52.60% (162) 162 / 308 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@Ryukemeister Ryukemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested, works perfectly!

@ThyMinimalDev ThyMinimalDev merged commit b748b8d into main Apr 10, 2024
37 of 39 checks passed
@ThyMinimalDev ThyMinimalDev deleted the scope-platform-atoms-css branch April 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants