Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: org-redirect-url-admin-update #14493

Merged
merged 1 commit into from Apr 10, 2024

Conversation

sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Apr 10, 2024

TL;DR

Fixes: #14246

Related issue for updating team slugs: #14494

🎥 Video uploaded on Graphite:

This pull request includes changes to ensure temporary organization redirects are updated when a user's profile is updated.

How to test?

To test, update a user's profile, ideally a username change, and check if the temporary organization redirect URLs have been updated accordingly.

Fixes CAL-3381

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 0:37am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Apr 10, 2024 0:37am
calcom-web-canary ⬜️ Ignored (Inspect) Apr 10, 2024 0:37am
qa ⬜️ Ignored (Inspect) Apr 10, 2024 0:37am

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sean-brydon and the rest of your teammates on Graphite Graphite

@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 10, 2024
@sean-brydon sean-brydon requested a review from a team April 10, 2024 12:37
@sean-brydon sean-brydon marked this pull request as ready for review April 10, 2024 12:37
@graphite-app graphite-app bot requested a review from a team April 10, 2024 12:37
@dosubot dosubot bot added admin 🐛 bug Something isn't working labels Apr 10, 2024
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fourteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 409.87 KB 638.11 KB 182.32% (🟢 -0.29%)
/[user]/[type]/embed 409.88 KB 638.11 KB 182.32% (🟢 -0.29%)
/apps/[slug]/[...pages] 584.25 KB 812.48 KB 232.14% (🟢 -0.26%)
/availability/troubleshoot 201.1 KB 429.33 KB 122.67% (🟢 -0.28%)
/d/[link]/[slug] 409.68 KB 637.92 KB 182.26% (🟢 -0.29%)
/event-types 553.86 KB 782.1 KB 223.46% (🟢 -0.26%)
/event-types/[type] 432.8 KB 661.03 KB 188.87% (🟢 -0.26%)
/org/[orgSlug]/[user]/[type] 410.08 KB 638.32 KB 182.38% (🟢 -0.29%)
/org/[orgSlug]/[user]/[type]/embed 410.1 KB 638.34 KB 182.38% (🟢 -0.28%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 409.7 KB 637.94 KB 182.27% (🟢 -0.29%)
/org/[orgSlug]/team/[slug]/[type] 409.89 KB 638.13 KB 182.32% (🟢 -0.29%)
/settings/my-account/out-of-office 265.33 KB 493.56 KB 141.02% (🟢 -0.26%)
/team/[slug]/[type] 409.86 KB 638.1 KB 182.31% (🟢 -0.28%)
/team/[slug]/[type]/embed 409.89 KB 638.13 KB 182.32% (🟢 -0.29%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

deploysentinel bot commented Apr 10, 2024

Current Playwright Test Results Summary

✅ 301 Passing - ⚠️ 19 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/10/2024 12:50:46pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7861c24

Started: 04/10/2024 12:47:03pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified
Retry 2Retry 1Initial Attempt
2.68% (8) 8 / 298 runs
failed over last 7 days
16.44% (49) 49 / 298 runs
flaked over last 7 days

📄   apps/web/playwright/locale.e2e.ts • 13 Flakes

Top 1 Common Error Messages

null

13 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
unauthorized user sees correct translations (de) should use correct translations and html attributes
Retry 1Initial Attempt
-3.08% (-9) -9 / 292 runs
failed over last 7 days
3.42% (10) 10 / 292 runs
flaked over last 7 days
unauthorized user sees correct translations (zh) should use correct translations and html attributes
Retry 1Initial Attempt
-3.45% (-10) -10 / 290 runs
failed over last 7 days
3.45% (10) 10 / 290 runs
flaked over last 7 days
unauthorized user sees correct translations (ar) should use correct translations and html attributes
Retry 1Initial Attempt
-3.09% (-9) -9 / 291 runs
failed over last 7 days
3.44% (10) 10 / 291 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-CN) should use correct translations and html attributes
Retry 1Initial Attempt
-3.10% (-9) -9 / 290 runs
failed over last 7 days
3.45% (10) 10 / 290 runs
flaked over last 7 days
unauthorized user sees correct translations (zh-TW) should use correct translations and html attributes
Retry 1Initial Attempt
-3.46% (-10) -10 / 289 runs
failed over last 7 days
3.46% (10) 10 / 289 runs
flaked over last 7 days
unauthorized user sees correct translations (pt) should use correct translations and html attributes
Retry 1Initial Attempt
-3.46% (-10) -10 / 289 runs
failed over last 7 days
3.46% (10) 10 / 289 runs
flaked over last 7 days
unauthorized user sees correct translations (pt-br) should use correct translations and html attributes
Retry 1Initial Attempt
-3.46% (-10) -10 / 289 runs
failed over last 7 days
3.46% (10) 10 / 289 runs
flaked over last 7 days
unauthorized user sees correct translations (es-419) should use correct translations and html attributes
Retry 1Initial Attempt
-3.46% (-10) -10 / 289 runs
failed over last 7 days
3.46% (10) 10 / 289 runs
flaked over last 7 days
authorized user sees correct translations (pt-br) should return correct translations and html attributes
Retry 1Initial Attempt
-3.47% (-10) -10 / 288 runs
failed over last 7 days
3.47% (10) 10 / 288 runs
flaked over last 7 days
authorized user sees correct translations (de) should return correct translations and html attributes
Retry 1Initial Attempt
-3.11% (-9) -9 / 289 runs
failed over last 7 days
3.46% (10) 10 / 289 runs
flaked over last 7 days
authorized user sees correct translations (ar) should return correct translations and html attributes
Retry 1Initial Attempt
-3.13% (-9) -9 / 288 runs
failed over last 7 days
3.47% (10) 10 / 288 runs
flaked over last 7 days
authorized user sees changed translations (de->ar) should return correct translations and html attributes
Retry 1Initial Attempt
-3.14% (-9) -9 / 287 runs
failed over last 7 days
3.48% (10) 10 / 287 runs
flaked over last 7 days
authorized user sees changed translations (de->pt-BR) [locale1] should return correct translations and html attributes
Retry 1Initial Attempt
-1.75% (-5) -5 / 286 runs
failed over last 7 days
2.80% (8) 8 / 286 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user can add multiple organizer address
Retry 1Initial Attempt
0.67% (2) 2 / 300 runs
failed over last 7 days
14.67% (44) 44 / 300 runs
flaked over last 7 days
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1Initial Attempt
0% (0) 0 / 297 runs
failed over last 7 days
3.03% (9) 9 / 297 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to Org
Retry 1Initial Attempt
0.35% (1) 1 / 287 run
failed over last 7 days
7.32% (21) 21 / 287 runs
flaked over last 7 days

📄   apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Signup Flow Test Email verification sent if enabled
Retry 1Initial Attempt
0% (0) 0 / 308 runs
failed over last 7 days
2.27% (7) 7 / 308 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
2.34% (7) 7 / 299 runs
failed over last 7 days
33.78% (101) 101 / 299 runs
flaked over last 7 days

View Detailed Build Results


Copy link

graphite-app bot commented Apr 10, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode added the High priority Created by Linear-GitHub Sync label Apr 10, 2024
Copy link

linear bot commented Apr 10, 2024

@keithwillcode keithwillcode marked this pull request as draft April 10, 2024 14:41
@keithwillcode keithwillcode marked this pull request as ready for review April 10, 2024 14:41
@zomars zomars merged commit dbafda9 into main Apr 10, 2024
42 checks passed
@zomars zomars deleted the 04-10-fix_org-redirect-url-admin-update branch April 10, 2024 18:48
@dosubot dosubot bot modified the milestones: v4.1, v4.0 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin 🐛 bug Something isn't working consumer core area: core, team members only High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3320] fix: when updating username by admin portal - update profile too
3 participants