fix: Broken SSR for event booking pages #14497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hariombalhara and the rest of your teammates on |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seventy-five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 302 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/11/2024 04:41:30am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a54e31e Started: 04/11/2024 04:38:31am UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
5.54% (16)16 / 289 runsfailed over last 7 days |
23.88% (69)69 / 289 runsflaked over last 7 days |
|
Login and logout tests -- legacy Login flow validations -- future Should warn when user does not exist
Retry 1 • Initial Attempt |
0% (0)0 / 289 runsfailed over last 7 days |
2.77% (8)8 / 289 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 296 runsfailed over last 7 days |
34.12% (101)101 / 296 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0.34% (1)1 / 296 runfailed over last 7 days |
62.50% (185)185 / 296 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-167.27% (-184)-184 / 110 runsfailed over last 7 days |
167.27% (184)184 / 110 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-167.27% (-184)-184 / 110 runsfailed over last 7 days |
167.27% (184)184 / 110 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-166.36% (-183)-183 / 110 runsfailed over last 7 days |
167.27% (184)184 / 110 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-168.81% (-184)-184 / 109 runsfailed over last 7 days |
168.81% (184)184 / 109 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-168.81% (-184)-184 / 109 runsfailed over last 7 days |
168.81% (184)184 / 109 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-168.81% (-184)-184 / 109 runsfailed over last 7 days |
168.81% (184)184 / 109 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-168.81% (-184)-184 / 109 runsfailed over last 7 days |
168.81% (184)184 / 109 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 2 • Retry 1 • Initial Attempt |
1.37% (4)4 / 292 runsfailed over last 7 days |
26.03% (76)76 / 292 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 297 runsfailed over last 7 days |
35.35% (105)105 / 297 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.67% (2)2 / 297 runsfailed over last 7 days |
53.20% (158)158 / 297 runsflaked over last 7 days |
hariombalhara
changed the title
hariombalhara
commented
Apr 10, 2024
| // Trigger the page navigation | ||
| page.goto(`/${user.username}/30-min`), | ||
| ]); | ||
| const ssrResponse = await response.text(); |
There was a problem hiding this comment.
Important to verify on raw text as on client it gets fixed as soon as react hydration kicks in.
hariombalhara
force-pushed
the
04-10-fix_broken_ssr_for_event_type_pages
branch
from
0e4e9c7
to
501a9c7
Compare
hariombalhara
commented
Apr 10, 2024
| @@ -291,6 +292,7 @@ export const getPublicEvent = async ( | |||
| profile: getProfileFromEvent(eventWithUserProfiles), | |||
| users, | |||
| entity: { | |||
| fromRedirectOfNonOrgLink, | |||
There was a problem hiding this comment.
Send it back so that react query can sent it again and cached response can be served by react query.
hariombalhara
force-pushed
the
04-10-fix_broken_ssr_for_event_type_pages
branch
from
501a9c7
to
b4532a7
Compare
zomars
previously approved these changes
Apr 10, 2024
dosubot
bot
added
booking-page
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/11/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hariombalhara
commented
Apr 11, 2024
| @@ -234,7 +239,7 @@ async function moveTeam({ | |||
| await addTeamRedirect({ | |||
| oldTeamSlug: team.slug, | |||
| teamSlug: newSlug, | |||
| orgSlug: org.slug, | |||
| orgSlug: org.slug || (orgMetadata?.requestedSlug ?? null), | |||
There was a problem hiding this comment.
Found this while doing test that in case payment is required for the organization(which is true for cal.com), org.slug won't be set and thus we need to fallback to requestedSlug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes broken OG images.
Happened because React Query is unable to reuse already sent
/eventrequest's response and because SSR doesn’t wait for re-renders, it getseventasundefinedcausing the issue of OG image generation(which is completely SSR)It happened because of newly introduced param
orgRedirectionwhich is by default assumedfalsebut for React QueryorgRedirection=undefinedandorgRedirection=falseare two different queries.Wrote a failing test now that’s passing in the PR
Type of change
How should this be tested?
Mandatory Tasks