Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sub-team slug - update tempOrgRedirect #14523

Conversation

sean-brydon
Copy link
Member

Fixes: CAL-3381 #14494

When you update a sub teams slug - we also update the redirect URL to respect the new changes.

Copy link

linear bot commented Apr 11, 2024

@graphite-app graphite-app bot requested a review from a team April 11, 2024 12:03
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth core area: core, team members only teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Apr 11, 2024
Copy link
Contributor

github-actions bot commented Apr 11, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 1:12am
platform-starter-kit ❌ Failed (Inspect) Apr 16, 2024 1:12am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:12am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:12am
qa ⬜️ Ignored (Inspect) Apr 16, 2024 1:12am

Copy link

graphite-app bot commented Apr 11, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 11, 2024

Current Playwright Test Results Summary

✅ 302 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/16/2024 01:13:47am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a4aadcf

Started: 04/16/2024 01:10:07am UTC

⚠️ Flakes

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- legacy Time slots should be reserved when selected
Retry 1Initial Attempt
0.36% (1) 1 / 275 run
failed over last 7 days
7.27% (20) 20 / 275 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
6.91% (19) 19 / 275 runs
failed over last 7 days
24% (66) 66 / 275 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
5.69% (16) 16 / 281 runs
failed over last 7 days
38.43% (108) 108 / 281 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 271 runs
failed over last 7 days
43.91% (119) 119 / 271 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization
Retry 1Initial Attempt
1.08% (3) 3 / 277 runs
failed over last 7 days
15.16% (42) 42 / 277 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Email Embeds slots are loading for team event types
Retry 1Initial Attempt
2.11% (6) 6 / 284 runs
failed over last 7 days
1.41% (4) 4 / 284 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.74% (2) 2 / 271 runs
failed over last 7 days
54.61% (148) 148 / 271 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarinaWolli CarinaWolli enabled auto-merge (squash) April 15, 2024 17:31
@CarinaWolli CarinaWolli merged commit 39aa848 into main Apr 16, 2024
38 of 40 checks passed
@CarinaWolli CarinaWolli deleted the sean/cal-3381-when-a-org-admin-or-owner-updates-team-redirect-urls-do-not branch April 16, 2024 01:14
@vercel vercel bot temporarily deployed to Preview – dev April 16, 2024 01:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working consumer core area: core, team members only teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants