Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test #14535

Merged
merged 4 commits into from Apr 11, 2024
Merged

fix: test #14535

merged 4 commits into from Apr 11, 2024

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Apr 11, 2024

Reverts #14480. Though this change is absolutely needed we need to make the change everywhere so that caching also works everywhere(including SSR which is breaking due to it right now).

Reverting it only causes /event request to be possibly sent twice from client which isn't a functional issue at the moment.

image

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 11, 2024
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 4:56pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 4:56pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 4:56pm
qa ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 4:56pm

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite Graphite

@hariombalhara hariombalhara changed the title Consider requestedSlug as well for instances that require payment fix: test Apr 11, 2024
Copy link
Contributor

github-actions bot commented Apr 11, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 11, 2024

Current Playwright Test Results Summary

✅ 310 Passing - ⚠️ 10 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/11/2024 05:04:12pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 39af489

Started: 04/11/2024 04:59:03pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
2.65% (9) 9 / 340 runs
failed over last 7 days
14.71% (50) 50 / 340 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0% (0) 0 / 342 runs
failed over last 7 days
63.45% (217) 217 / 342 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-172.80% (-216) -216 / 125 runs
failed over last 7 days
172.80% (216) 216 / 125 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-172.80% (-216) -216 / 125 runs
failed over last 7 days
172.80% (216) 216 / 125 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-171.20% (-214) -214 / 125 runs
failed over last 7 days
172.80% (216) 216 / 125 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-175.61% (-216) -216 / 123 runs
failed over last 7 days
175.61% (216) 216 / 123 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-175.61% (-216) -216 / 123 runs
failed over last 7 days
175.61% (216) 216 / 123 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-175.61% (-216) -216 / 123 runs
failed over last 7 days
175.61% (216) 216 / 123 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-175.61% (-216) -216 / 123 runs
failed over last 7 days
175.61% (216) 216 / 123 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
2.34% (8) 8 / 342 runs
failed over last 7 days
33.33% (114) 114 / 342 runs
flaked over last 7 days

View Detailed Build Results


…ut right now that is not breaking functionality
@hariombalhara hariombalhara marked this pull request as ready for review April 11, 2024 17:04
@graphite-app graphite-app bot requested a review from a team April 11, 2024 17:04
@dosubot dosubot bot added event-types area: event types, event-types foundation 🐛 bug Something isn't working labels Apr 11, 2024
Copy link

graphite-app bot commented Apr 11, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@ThyMinimalDev ThyMinimalDev merged commit af0cc5c into main Apr 11, 2024
41 checks passed
@ThyMinimalDev ThyMinimalDev deleted the fix-test branch April 11, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working consumer core area: core, team members only event-types area: event types, event-types foundation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants