Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: Redirect only those apps that extend 'EventType' to the new apps install flow" #14539

Merged
merged 1 commit into from Apr 11, 2024

Conversation

exception
Copy link
Contributor

Reverts #14527

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 6:54pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
calcom-web-canary ⬜️ Ignored (Inspect) Apr 11, 2024 6:54pm

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only 📉 regressing This used to work. Now it doesn't anymore. labels Apr 11, 2024
@keithwillcode keithwillcode added the platform Anything related to our platform plan label Apr 11, 2024
@graphite-app graphite-app bot requested a review from a team April 11, 2024 18:52
@keithwillcode keithwillcode changed the title Revert "fix: Redirect only those apps that extend 'EventType' to the new apps install flow" revert: "fix: Redirect only those apps that extend 'EventType' to the new apps install flow" Apr 11, 2024
@exception exception enabled auto-merge (squash) April 11, 2024 18:55
Copy link

graphite-app bot commented Apr 11, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (04/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 11, 2024

Current Playwright Test Results Summary

✅ 310 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/11/2024 07:08:11pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 67b15c8

Started: 04/11/2024 07:04:40pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2Retry 1Initial Attempt
5.23% (18) 18 / 344 runs
failed over last 7 days
25.58% (88) 88 / 344 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- legacy Time slots should be reserved when selected
Retry 1Initial Attempt
0% (0) 0 / 360 runs
failed over last 7 days
9.72% (35) 35 / 360 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0% (0) 0 / 353 runs
failed over last 7 days
33.71% (119) 119 / 353 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2Retry 1Initial Attempt
1.39% (5) 5 / 360 runs
failed over last 7 days
25% (90) 90 / 360 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 354 runs
failed over last 7 days
38.42% (136) 136 / 354 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.56% (2) 2 / 354 runs
failed over last 7 days
53.95% (191) 191 / 354 runs
flaked over last 7 days

View Detailed Build Results


@exception exception merged commit 711aceb into main Apr 11, 2024
37 of 40 checks passed
@exception exception deleted the revert-14527-fix/shouldRedirectToAppOnboarding branch April 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only platform Anything related to our platform plan 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants