Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat: new App install flow" #14540

Merged
merged 1 commit into from Apr 11, 2024
Merged

Conversation

exception
Copy link
Contributor

Reverts #11975

@graphite-app graphite-app bot requested a review from a team April 11, 2024 19:11
Copy link
Contributor

github-actions bot commented Apr 11, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 7:18pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Apr 11, 2024 7:18pm
calcom-web-canary ⬜️ Ignored (Inspect) Apr 11, 2024 7:18pm
qa ⬜️ Ignored (Inspect) Apr 11, 2024 7:18pm

@dosubot dosubot bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only platform Anything related to our platform plan 📉 regressing This used to work. Now it doesn't anymore. labels Apr 11, 2024
@graphite-app graphite-app bot requested a review from a team April 11, 2024 19:12
Copy link

graphite-app bot commented Apr 11, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/categories 255.53 KB 483.86 KB 138.25% (🟡 +0.26%)
/apps/installed/[category] 278.97 KB 507.3 KB 144.94% (🟡 +0.20%)
/auth/forgot-password/[id] 106.38 KB 334.7 KB 95.63% (🟡 +0.22%)
/availability/[schedule] 409.54 KB 637.86 KB 182.25% (🟡 +0.26%)
/booking/[uid] 224.99 KB 453.31 KB 129.52% (🟡 +0.16%)
/booking/[uid]/embed 224.99 KB 453.32 KB 129.52% (🟡 +0.16%)
/bookings/[status] 323.28 KB 551.61 KB 157.60% (🟡 +0.26%)
/enterprise 255.59 KB 483.92 KB 138.26% (🟡 +0.26%)
/event-types 554.89 KB 783.22 KB 223.78% (🟡 +0.20%)
/event-types/[type] 433.98 KB 662.3 KB 189.23% (🟡 +0.18%)
/insights 474 KB 702.33 KB 200.66% (🟡 +0.26%)
/more 255.1 KB 483.42 KB 138.12% (🟡 +0.26%)
/settings/admin 261.41 KB 489.73 KB 139.92% (🟡 +0.26%)
/settings/admin/apps 274.47 KB 502.8 KB 143.66% (🟡 +0.26%)
/settings/admin/apps/[category] 274.46 KB 502.79 KB 143.65% (🟡 +0.26%)
/settings/admin/flags 265.21 KB 493.53 KB 141.01% (🟡 +0.26%)
/settings/admin/impersonation 261.71 KB 490.03 KB 140.01% (🟡 +0.26%)
/settings/admin/oAuth 273.41 KB 501.74 KB 143.35% (🟡 +0.27%)
/settings/admin/orgMigrations/_OrgMigrationLayout 250 KB 478.32 KB 136.66% (🟡 +0.26%)
/settings/admin/orgMigrations/moveTeamToOrg 299.48 KB 527.81 KB 150.80% (🟡 +0.26%)
/settings/admin/orgMigrations/moveUserToOrg 318.64 KB 546.97 KB 156.28% (🟡 +0.26%)
/settings/admin/orgMigrations/removeTeamFromOrg 299.24 KB 527.57 KB 150.73% (🟡 +0.26%)
/settings/admin/orgMigrations/removeUserFromOrg 299.25 KB 527.58 KB 150.74% (🟡 +0.26%)
/settings/admin/organizations 263.29 KB 491.61 KB 140.46% (🟡 +0.26%)
/settings/admin/organizations/[id]/edit 261.96 KB 490.28 KB 140.08% (🟡 +0.26%)
/settings/admin/users 264.05 KB 492.38 KB 140.68% (🟡 +0.26%)
/settings/admin/users/[id]/edit 392.3 KB 620.63 KB 177.32% (🟡 +0.26%)
/settings/admin/users/add 391.97 KB 620.3 KB 177.23% (🟡 +0.26%)
/settings/billing 261.61 KB 489.94 KB 139.98% (🟡 +0.26%)
/settings/developer/api-keys 265.98 KB 494.31 KB 141.23% (🟡 +0.26%)
/settings/developer/webhooks 266.11 KB 494.44 KB 141.27% (🟡 +0.26%)
/settings/developer/webhooks/[id] 267.05 KB 495.38 KB 141.54% (🟡 +0.26%)
/settings/developer/webhooks/new 267.09 KB 495.42 KB 141.55% (🟡 +0.26%)
/settings/my-account/appearance 313.98 KB 542.31 KB 154.95% (🟡 +0.26%)
/settings/my-account/calendars 272.58 KB 500.91 KB 143.12% (🟡 +0.19%)
/settings/my-account/conferencing 273.47 KB 501.79 KB 143.37% (🟡 +0.19%)
/settings/my-account/general 349.53 KB 577.85 KB 165.10% (🟡 +0.26%)
/settings/my-account/out-of-office 266.59 KB 494.92 KB 141.41% (🟡 +0.26%)
/settings/my-account/profile 404.77 KB 633.1 KB 180.89% (🟡 +0.26%)
/settings/organizations/[id]/onboard-members 171.47 KB 399.8 KB 114.23% (🟡 +0.16%)
/settings/organizations/appearance 285.13 KB 513.46 KB 146.70% (🟡 +0.26%)
/settings/organizations/billing 261.65 KB 489.97 KB 139.99% (🟡 +0.26%)
/settings/organizations/general 349.51 KB 577.84 KB 165.10% (🟡 +0.26%)
/settings/organizations/platform/oauth-clients 263.44 KB 491.77 KB 140.51% (🟡 +0.26%)
/settings/organizations/platform/oauth-clients/create 263 KB 491.33 KB 140.38% (🟡 +0.26%)
/settings/organizations/privacy 267 KB 495.32 KB 141.52% (🟡 +0.26%)
/settings/organizations/profile 396.29 KB 624.61 KB 178.46% (🟡 +0.26%)
/settings/organizations/sso 272.26 KB 500.59 KB 143.02% (🟡 +0.27%)
/settings/organizations/teams/other 262.47 KB 490.8 KB 140.23% (🟡 +0.26%)
/settings/organizations/teams/other/[id]/appearance 274.14 KB 502.47 KB 143.56% (🟡 +0.26%)
/settings/organizations/teams/other/[id]/members 268.94 KB 497.27 KB 142.08% (🟡 +0.26%)
/settings/organizations/teams/other/[id]/profile 467.56 KB 695.89 KB 198.83% (🟡 +0.16%)
/settings/security/impersonation 266.79 KB 495.12 KB 141.46% (🟡 +0.26%)
/settings/security/password 304.35 KB 532.68 KB 152.19% (🟡 +0.27%)
/settings/security/sso 271.66 KB 499.99 KB 142.85% (🟡 +0.26%)
/settings/security/two-factor-auth 270.26 KB 498.58 KB 142.45% (🟡 +0.26%)
/settings/teams 261.15 KB 489.47 KB 139.85% (🟡 +0.26%)
/settings/teams/[id]/appearance 274.13 KB 502.45 KB 143.56% (🟡 +0.26%)
/settings/teams/[id]/billing 261.65 KB 489.98 KB 139.99% (🟡 +0.27%)
/settings/teams/[id]/members 380.89 KB 609.22 KB 174.06% (🟡 +0.26%)
/settings/teams/[id]/onboard-members 170.65 KB 398.97 KB 113.99% (🟡 +0.16%)
/settings/teams/[id]/profile 468.4 KB 696.73 KB 199.07% (🟡 +0.16%)
/settings/teams/new 198.08 KB 426.4 KB 121.83% (🟡 +0.24%)
/signup 178.57 KB 406.9 KB 116.26% (🟡 +0.25%)
/teams 255.32 KB 483.65 KB 138.19% (🟡 +0.26%)
/upgrade 255.44 KB 483.77 KB 138.22% (🟡 +0.26%)
/workflows 286.57 KB 514.9 KB 147.11% (🟡 +0.26%)
/workflows/[workflow] 408.76 KB 637.08 KB 182.02% (🟡 +0.26%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

deploysentinel bot commented Apr 11, 2024

Current Playwright Test Results Summary

✅ 310 Passing - ⚠️ 21 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/11/2024 07:31:11pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5f9ec01

Started: 04/11/2024 07:25:02pm UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 4 Flakes

Top 1 Common Error Messages

null

4 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 2Retry 1Initial Attempt
2.53% (9) 9 / 356 runs
failed over last 7 days
32.87% (117) 117 / 356 runs
flaked over last 7 days
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
1.42% (5) 5 / 351 runs
failed over last 7 days
24.50% (86) 86 / 351 runs
flaked over last 7 days
Stripe integration Paid booking should be able to be rescheduled
Retry 2Retry 1Initial Attempt
1.99% (7) 7 / 351 runs
failed over last 7 days
5.98% (21) 21 / 351 runs
flaked over last 7 days
Stripe integration Paid booking should be able to be cancelled
Retry 2Retry 1Initial Attempt
0.85% (3) 3 / 351 runs
failed over last 7 days
6.27% (22) 22 / 351 runs
flaked over last 7 days

📄   apps/web/playwright/impersonation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Users can impersonate App Admin can impersonate users with impersonation enabled
Retry 1Initial Attempt
0.85% (3) 3 / 351 runs
failed over last 7 days
4.84% (17) 17 / 351 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 2Retry 1Initial Attempt
0% (0) 0 / 355 runs
failed over last 7 days
34.08% (121) 121 / 355 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity Can manage single schedule
Retry 1Initial Attempt
0.27% (1) 1 / 367 run
failed over last 7 days
23.71% (87) 87 / 367 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2Retry 1Initial Attempt
1.38% (5) 5 / 362 runs
failed over last 7 days
25.14% (91) 91 / 362 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1Initial Attempt
10.63% (39) 39 / 367 runs
failed over last 7 days
31.88% (117) 117 / 367 runs
flaked over last 7 days
Teams - NonOrg -- future Can create a private team
Retry 1Initial Attempt
0.27% (1) 1 / 368 run
failed over last 7 days
1.36% (5) 5 / 368 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to an organization
Retry 1Initial Attempt
0% (0) 0 / 363 runs
failed over last 7 days
11.29% (41) 41 / 363 runs
flaked over last 7 days
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done existing user migrated to an organization
Retry 1Initial Attempt
0% (0) 0 / 355 runs
failed over last 7 days
3.10% (11) 11 / 355 runs
flaked over last 7 days

📄   apps/web/playwright/bookings-list.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Upcoming bookings managed eventType booking should be visible to team admin
Retry 1Initial Attempt
6.49% (5) 5 / 77 runs
failed over last 7 days
20.78% (16) 16 / 77 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
0% (0) 0 / 355 runs
failed over last 7 days
63.66% (226) 226 / 355 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-174.42% (-225) -225 / 129 runs
failed over last 7 days
174.42% (225) 225 / 129 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-174.42% (-225) -225 / 129 runs
failed over last 7 days
174.42% (225) 225 / 129 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-177.17% (-225) -225 / 127 runs
failed over last 7 days
177.17% (225) 225 / 127 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-172.87% (-223) -223 / 129 runs
failed over last 7 days
174.42% (225) 225 / 129 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-177.17% (-225) -225 / 127 runs
failed over last 7 days
177.17% (225) 225 / 127 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-177.17% (-225) -225 / 127 runs
failed over last 7 days
177.17% (225) 225 / 127 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-177.17% (-225) -225 / 127 runs
failed over last 7 days
177.17% (225) 225 / 127 runs
flaked over last 7 days

View Detailed Build Results


@exception exception enabled auto-merge (squash) April 11, 2024 19:38
@exception exception changed the title revert "feat: new App install flow" revert: "feat: new App install flow" Apr 11, 2024
@exception exception merged commit 5071e65 into main Apr 11, 2024
40 checks passed
@exception exception deleted the revert-11975-new-app-install-flow branch April 11, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only platform Anything related to our platform plan 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants