refactor: v2 event types endpoint paths #14545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
api
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
supalarry
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/12/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (04/12/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Current Playwright Test Results Summary✅ 302 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/13/2024 08:38:26am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2ce5f4f Started: 04/13/2024 08:35:17am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests can add single organizer address location without display location public option
Retry 1 • Initial Attempt |
0.38% (1)1 / 262 runfailed over last 7 days |
2.67% (7)7 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity Can manage single schedule
Retry 1 • Initial Attempt |
0.37% (1)1 / 273 runfailed over last 7 days |
25.27% (69)69 / 273 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
4.71% (12)12 / 255 runsfailed over last 7 days |
30.98% (79)79 / 255 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 263 runsfailed over last 7 days |
40.68% (107)107 / 263 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0% (0)0 / 263 runsfailed over last 7 days |
65.40% (172)172 / 263 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-190% (-171)-171 / 90 runsfailed over last 7 days |
190% (171)171 / 90 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-190% (-171)-171 / 90 runsfailed over last 7 days |
190% (171)171 / 90 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-187.78% (-169)-169 / 90 runsfailed over last 7 days |
190% (171)171 / 90 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-194.32% (-171)-171 / 88 runsfailed over last 7 days |
194.32% (171)171 / 88 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-194.32% (-171)-171 / 88 runsfailed over last 7 days |
194.32% (171)171 / 88 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-194.32% (-171)-171 / 88 runsfailed over last 7 days |
194.32% (171)171 / 88 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-194.32% (-171)-171 / 88 runsfailed over last 7 days |
194.32% (171)171 / 88 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.76% (2)2 / 263 runsfailed over last 7 days |
52.85% (139)139 / 263 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
…ka ex. events/public
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
ThyMinimalDev
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1 The signature of URL has changed from passing username and eventSlug as query params to query segments.
2.2 This part of commit moves input DTO that events expected from platform types to v2 folder, because the type was not used outside of v2, and also now the input DTO does not have username and eventSlug in it because they are in URL.
2.3 Update "useEventTypesPublic" to point to this endpoint.
2.4 Document it's return in swagger in this commit.
Besides e2e tests - confirmed that in the examples app and in cal web app can book and event and then see event in bokings.