Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: view team bookings (#14079)" #14561

Merged
merged 1 commit into from Apr 13, 2024
Merged

Conversation

keithwillcode
Copy link
Contributor

This reverts commit f86c448 due to DB performance problems. We need to completely rethink how we load this data. Potentially we consider a different page layout, views, pre-generated DTOs, etc. to accomplish this without introducing severe perf problems.

@keithwillcode keithwillcode added the Urgent Created by Linear-GitHub Sync label Apr 13, 2024
@keithwillcode keithwillcode added this to the v4.0 milestone Apr 13, 2024
@keithwillcode keithwillcode requested review from a team April 13, 2024 00:30
@keithwillcode keithwillcode self-assigned this Apr 13, 2024
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only foundation labels Apr 13, 2024
@keithwillcode keithwillcode marked this pull request as ready for review April 13, 2024 00:30
@dosubot dosubot bot added automated-tests area: unit tests, e2e tests, playwright bookings area: bookings, availability, timezones, double booking performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive 📉 regressing This used to work. Now it doesn't anymore. labels Apr 13, 2024
Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 0:31am

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 13, 2024

Current Playwright Test Results Summary

✅ 47 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/13/2024 12:52:09am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 47904ce

Started: 04/13/2024 12:50:33am UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
6.67% (17) 17 / 255 runs
failed over last 7 days
24.31% (62) 62 / 255 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode removed the automated-tests area: unit tests, e2e tests, playwright label Apr 13, 2024
@keithwillcode keithwillcode merged commit fd193e6 into main Apr 13, 2024
40 checks passed
@keithwillcode keithwillcode deleted the revert/team-bookings branch April 13, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking core area: core, team members only foundation performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive 📉 regressing This used to work. Now it doesn't anymore. Urgent Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants