chore: fix class type and bump atoms version #14562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
dosubot
bot
added
bookings
keithwillcode
added
api
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/react-intersection-observer@8.34.0 |
keithwillcode
previously approved these changes
Apr 13, 2024
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (04/13/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (04/13/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
keithwillcode
requested changes
Apr 13, 2024
keithwillcode
approved these changes
Apr 13, 2024
Current Playwright Test Results Summary✅ 302 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/13/2024 01:20:05am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a8b9dfb Started: 04/13/2024 01:16:31am UTC
|
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
4.20% (11)11 / 262 runsfailed over last 7 days |
35.11% (92)92 / 262 runsflaked over last 7 days |
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 2 • Retry 1 • Initial Attempt |
1.57% (4)4 / 255 runsfailed over last 7 days |
22.35% (57)57 / 255 runsflaked over last 7 days |
|
Stripe integration Change stripe presented currency Should be able to change currency
Retry 1 • Initial Attempt |
0% (0)0 / 250 runsfailed over last 7 days |
1.60% (4)4 / 250 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0.77% (2)2 / 260 runsfailed over last 7 days |
4.62% (12)12 / 260 runsflaked over last 7 days |
|
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 257 runsfailed over last 7 days |
4.28% (11)11 / 257 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Newly added secondary email should show as Unverified
Retry 1 • Initial Attempt |
0.78% (2)2 / 257 runsfailed over last 7 days |
8.17% (21)21 / 257 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 257 runsfailed over last 7 days |
40.47% (104)104 / 257 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.78% (2)2 / 257 runsfailed over last 7 days |
52.92% (136)136 / 257 runsflaked over last 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes classNames type and bump version of atoms package