Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove PageWrapper #14579

Merged
merged 2 commits into from Apr 14, 2024
Merged

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Apr 14, 2024

What does this PR do?

Remove PageWrapper

@graphite-app graphite-app bot requested a review from a team April 14, 2024 16:26
@emrysal emrysal enabled auto-merge (squash) April 14, 2024 16:26
@dosubot dosubot bot added core area: core, team members only 🐛 bug Something isn't working labels Apr 14, 2024
Copy link
Contributor

github-actions bot commented Apr 14, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2024 4:29pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2024 4:29pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2024 4:29pm

@emrysal emrysal disabled auto-merge April 14, 2024 16:29
Copy link

graphite-app bot commented Apr 14, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@emrysal emrysal enabled auto-merge (squash) April 14, 2024 16:31
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eighty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 275.78 KB 504.11 KB 144.03% (🟢 -0.50%)
/apps/[slug] 293.95 KB 522.29 KB 149.22% (🟢 -0.37%)
/apps/[slug]/[...pages] 584.4 KB 812.73 KB 232.21% (🟢 -0.38%)
/apps/categories 253.68 KB 482.01 KB 137.72% (🟢 -0.53%)
/apps/categories/[category] 258.46 KB 486.8 KB 139.09% (🟢 -0.40%)
/apps/installed/[category] 277.99 KB 506.32 KB 144.66% (🟢 -0.28%)
/auth/forgot-password/[id] 105.75 KB 334.08 KB 95.45% (🟢 -0.18%)
/auth/setup 148.71 KB 377.05 KB 107.73% (🟢 -0.22%)
/availability 461.8 KB 690.14 KB 197.18% (🟢 -0.33%)
/availability/[schedule] 408.04 KB 636.37 KB 181.82% (🟢 -0.53%)
/bookings/[status] 321.43 KB 549.76 KB 157.08% (🟢 -0.54%)
/enterprise 253.74 KB 482.07 KB 137.73% (🟢 -0.53%)
/event-types 553.51 KB 781.84 KB 223.38% (🟢 -0.47%)
/event-types/[type] 432.66 KB 660.99 KB 188.85% (🟢 -0.45%)
/getting-started/[[...step]] 404.85 KB 633.18 KB 180.91% (🟡 +0.15%)
/insights 472.15 KB 700.48 KB 200.14% (🟢 -0.53%)
/maintenance 30.57 KB 258.9 KB 73.97% (🟢 -15.57%)
/more 253.25 KB 481.58 KB 137.59% (🟢 -0.53%)
/settings/admin 259.55 KB 487.89 KB 139.40% (🟢 -0.53%)
/settings/admin/apps 272.62 KB 500.95 KB 143.13% (🟢 -0.53%)
/settings/admin/apps/[category] 272.61 KB 500.94 KB 143.13% (🟢 -0.54%)
/settings/admin/flags 263.36 KB 491.69 KB 140.48% (🟢 -0.53%)
/settings/admin/impersonation 259.86 KB 488.19 KB 139.48% (🟢 -0.53%)
/settings/admin/oAuth 271.56 KB 499.9 KB 142.83% (🟢 -0.53%)
/settings/admin/oAuth/oAuthView 94.13 KB 322.46 KB 92.13% (🟢 -0.16%)
/settings/admin/orgMigrations/_OrgMigrationLayout 248.15 KB 476.48 KB 136.14% (🟢 -0.53%)
/settings/admin/orgMigrations/moveTeamToOrg 297.63 KB 525.97 KB 150.28% (🟢 -0.53%)
/settings/admin/orgMigrations/moveUserToOrg 316.83 KB 545.16 KB 155.76% (🟢 -0.53%)
/settings/admin/orgMigrations/removeTeamFromOrg 297.39 KB 525.73 KB 150.21% (🟢 -0.53%)
/settings/admin/orgMigrations/removeUserFromOrg 297.41 KB 525.74 KB 150.21% (🟢 -0.53%)
/settings/admin/organizations 261.43 KB 489.77 KB 139.93% (🟢 -0.53%)
/settings/admin/organizations/[id]/edit 260.11 KB 488.44 KB 139.55% (🟢 -0.53%)
/settings/admin/users 262.2 KB 490.53 KB 140.15% (🟢 -0.53%)
/settings/admin/users/[id]/edit 390.48 KB 618.81 KB 176.80% (🟢 -0.53%)
/settings/admin/users/add 390.15 KB 618.48 KB 176.71% (🟢 -0.53%)
/settings/billing 259.76 KB 488.09 KB 139.46% (🟢 -0.53%)
/settings/developer/api-keys 264.13 KB 492.47 KB 140.70% (🟢 -0.53%)
/settings/developer/webhooks 264.26 KB 492.6 KB 140.74% (🟢 -0.53%)
/settings/developer/webhooks/[id] 265.72 KB 494.05 KB 141.16% (🟢 -0.39%)
/settings/developer/webhooks/new 265.77 KB 494.11 KB 141.17% (🟢 -0.38%)
/settings/my-account/appearance 312.13 KB 540.47 KB 154.42% (🟢 -0.53%)
/settings/my-account/calendars 271.66 KB 500 KB 142.86% (🟢 -0.27%)
/settings/my-account/conferencing 271.97 KB 500.3 KB 142.94% (🟢 -0.42%)
/settings/my-account/general 377.32 KB 605.65 KB 173.04% (🟢 -0.53%)
/settings/my-account/out-of-office 264.74 KB 493.07 KB 140.88% (🟢 -0.53%)
/settings/my-account/profile 402.92 KB 631.26 KB 180.36% (🟢 -0.53%)
/settings/organizations/[id]/about 155.36 KB 383.7 KB 109.63% (🟢 -0.21%)
/settings/organizations/[id]/add-teams 155.35 KB 383.69 KB 109.62% (🟢 -0.20%)
/settings/organizations/[id]/onboard-members 170.55 KB 398.88 KB 113.97% (🟢 -0.27%)
/settings/organizations/appearance 283.28 KB 511.62 KB 146.18% (🟢 -0.53%)
/settings/organizations/billing 259.79 KB 488.13 KB 139.47% (🟢 -0.54%)
/settings/organizations/dsync 329.92 KB 558.25 KB 159.50% (🟢 -0.40%)
/settings/organizations/general 347.68 KB 576.01 KB 164.57% (🟢 -0.53%)
/settings/organizations/members 428.43 KB 656.76 KB 187.65% (🟢 -0.34%)
/settings/organizations/new 155.37 KB 383.7 KB 109.63% (🟢 -0.21%)
/settings/organizations/platform/oauth-clients 261.59 KB 489.92 KB 139.98% (🟢 -0.53%)
/settings/organizations/platform/oauth-clients/create 261.15 KB 489.48 KB 139.85% (🟢 -0.53%)
/settings/organizations/privacy 265.14 KB 493.48 KB 140.99% (🟢 -0.53%)
/settings/organizations/profile 394.44 KB 622.77 KB 177.93% (🟢 -0.53%)
/settings/organizations/sso 270.41 KB 498.74 KB 142.50% (🟢 -0.53%)
/settings/organizations/teams/other 260.62 KB 488.96 KB 139.70% (🟢 -0.53%)
/settings/organizations/teams/other/[id]/appearance 272.29 KB 500.62 KB 143.03% (🟢 -0.53%)
/settings/organizations/teams/other/[id]/members 267.09 KB 495.43 KB 141.55% (🟢 -0.53%)
/settings/organizations/teams/other/[id]/profile 466.05 KB 694.38 KB 198.39% (🟢 -0.43%)
/settings/security/impersonation 264.94 KB 493.28 KB 140.94% (🟢 -0.53%)
/settings/security/password 302.51 KB 530.84 KB 151.67% (🟢 -0.53%)
/settings/security/sso 269.81 KB 498.14 KB 142.33% (🟢 -0.53%)
/settings/security/two-factor-auth 268.41 KB 496.74 KB 141.93% (🟢 -0.53%)
/settings/teams 259.3 KB 487.63 KB 139.32% (🟢 -0.53%)
/settings/teams/[id]/appearance 272.27 KB 500.61 KB 143.03% (🟢 -0.53%)
/settings/teams/[id]/billing 259.8 KB 488.13 KB 139.47% (🟢 -0.54%)
/settings/teams/[id]/members 379.06 KB 607.4 KB 173.54% (🟢 -0.53%)
/settings/teams/[id]/onboard-members 169.73 KB 398.06 KB 113.73% (🟢 -0.26%)
/settings/teams/[id]/profile 466.89 KB 695.22 KB 198.64% (🟢 -0.44%)
/settings/teams/new 196.85 KB 425.18 KB 121.48% (🟢 -0.35%)
/signup 177.84 KB 406.17 KB 116.05% (🟢 -0.21%)
/teams 253.47 KB 481.8 KB 137.66% (🟢 -0.53%)
/upgrade 253.59 KB 481.93 KB 137.69% (🟢 -0.53%)
/workflows 284.75 KB 513.08 KB 146.59% (🟢 -0.53%)
/workflows/[workflow] 406.98 KB 635.31 KB 181.52% (🟢 -0.53%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

deploysentinel bot commented Apr 14, 2024

Current Playwright Test Results Summary

✅ 47 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/14/2024 08:45:15pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ae084c7

Started: 04/14/2024 08:43:49pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
2.14% (6) 6 / 280 runs
failed over last 7 days
12.86% (36) 36 / 280 runs
flaked over last 7 days

View Detailed Build Results


@zomars zomars disabled auto-merge April 14, 2024 16:41
@keithwillcode keithwillcode enabled auto-merge (squash) April 14, 2024 20:41
@keithwillcode keithwillcode merged commit 3d23978 into main Apr 14, 2024
39 checks passed
@keithwillcode keithwillcode deleted the bugfix/remove-page-wrapper-maintenance branch April 14, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only foundation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants