fix: acme.cal.local crashes due to missing requestedSlug in seed #14592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
dosubot
bot
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (04/15/24)1 reviewer was added to this PR based on Keith Williams's automation. |
sean-brydon
approved these changes
Apr 15, 2024
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 302 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/15/2024 05:51:59pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 6fa52f4 Started: 04/15/2024 05:48:24pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
4.29% (12)12 / 280 runsfailed over last 7 days |
30.71% (86)86 / 280 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization
Retry 1 • Initial Attempt |
1.70% (5)5 / 294 runsfailed over last 7 days |
15.31% (45)45 / 294 runsflaked over last 7 days |
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to a team inside organization
Retry 1 • Initial Attempt |
1.40% (4)4 / 286 runsfailed over last 7 days |
10.14% (29)29 / 286 runsflaked over last 7 days |
📄 apps/web/playwright/availability.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity Date Overrides
Retry 1 • Initial Attempt |
0.34% (1)1 / 298 runfailed over last 7 days |
2.35% (7)7 / 298 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.35% (1)1 / 287 runfailed over last 7 days |
33.10% (95)95 / 287 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
5.37% (16)16 / 298 runsfailed over last 7 days |
36.24% (108)108 / 298 runsflaked over last 7 days |
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
1.75% (5)5 / 286 runsfailed over last 7 days |
21.33% (61)61 / 286 runsflaked over last 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
requestedSlug should never be undefined as this value is passed back in the getServerSideProps (undefined is an invalid value and causes a crash; if undefined; it shouldn't be added).