Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom attributes not being synced in intercom #14600

Merged

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Apr 16, 2024

Fixes:

a lot of users have undefined data in their custom data in intercom
they basically contact us, but our custom data is not being shared so there is no way to identify users

CleanShot 2024-04-15 at 20 59 50@2x

@graphite-app graphite-app bot requested a review from a team April 16, 2024 07:48
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 16, 2024
Copy link

vercel bot commented Apr 16, 2024

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added core area: core, team members only platform Anything related to our platform plan 🐛 bug Something isn't working labels Apr 16, 2024
@graphite-app graphite-app bot requested a review from a team April 16, 2024 07:48
Copy link

graphite-app bot commented Apr 16, 2024

Graphite Automations

"Add community label" took an action on this PR • (04/16/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (04/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@@ -215,15 +215,17 @@ const useBanners = () => {
const Layout = (props: LayoutProps) => {
const banners = useBanners();

const showIntercom = localStorage.getItem("showIntercom");
const { data: user } = trpc.viewer.me.useQuery();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you not user session here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main reason to use this here is because in useIntercom this api is called and the data is not available initially when boot() is called LINK,
so this is to re-run boot when the user data is available

@PeerRich PeerRich merged commit b61820d into calcom:main Apr 16, 2024
33 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants