New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom attributes not being synced in intercom #14600
fix: custom attributes not being synced in intercom #14600
Conversation
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (04/16/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (04/16/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (04/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@@ -215,15 +215,17 @@ const useBanners = () => { | |||
const Layout = (props: LayoutProps) => { | |||
const banners = useBanners(); | |||
|
|||
const showIntercom = localStorage.getItem("showIntercom"); | |||
const { data: user } = trpc.viewer.me.useQuery(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you not user session here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the main reason to use this here is because in useIntercom this api is called and the data is not available initially when boot() is called LINK,
so this is to re-run boot when the user data is available
Fixes:
a lot of users have undefined data in their custom data in intercom
they basically contact us, but our custom data is not being shared so there is no way to identify users