fix: 500 on forbidden showing up in logs #14636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
dosubot
bot
added
core
emrysal
commented
Apr 17, 2024
| @@ -56,8 +56,7 @@ export const eventOwnerProcedure = authedProcedure | |||
| })(); | |||
|
|
|||
| if (!isAuthorized) { | |||
| console.warn(`User ${ctx.user.id} attempted to an access an event ${event.id} they do not own.`); | |||
There was a problem hiding this comment.
We don't need this information - also FORBIDDEN is the right code to throw here.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (04/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 302 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/17/2024 03:59:19pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 881a1b8 Started: 04/17/2024 03:55:15pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
5.69% (17)17 / 299 runsfailed over last 7 days |
23.75% (71)71 / 299 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2 • Retry 1 • Initial Attempt |
7.19% (22)22 / 306 runsfailed over last 7 days |
37.58% (115)115 / 306 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.34% (1)1 / 294 runfailed over last 7 days |
37.07% (109)109 / 294 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.34% (1)1 / 296 runfailed over last 7 days |
53.72% (159)159 / 296 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration when enabling Stripe, team credentialId is included
Retry 1 • Initial Attempt |
3.29% (10)10 / 304 runsfailed over last 7 days |
1.32% (4)4 / 304 runsflaked over last 7 days |
keithwillcode
previously approved these changes
Apr 17, 2024
|
type check is still failing @emrysal |
CarinaWolli
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When accessing an event type that doesn't exist or doesn't belong to you, redirect back to the /event-types page instead of throwing a 500 error.
Future improvement, show toast or error, but practically this should happen only when intentional.