Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add linting exception for website #14645

Merged
merged 2 commits into from Apr 17, 2024

Conversation

zomars
Copy link
Member

@zomars zomars commented Apr 17, 2024

What does this PR do?

Needed to unblock website deployments

@graphite-app graphite-app bot requested a review from a team April 17, 2024 19:01
Copy link
Contributor

github-actions bot commented Apr 17, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added core area: core, team members only devops labels Apr 17, 2024
@keithwillcode keithwillcode added api area: API, enterprise API, access token, OAuth foundation labels Apr 17, 2024
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-starter-kit ❌ Failed (Inspect) Apr 17, 2024 7:34pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 7:34pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 7:34pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 7:34pm

@keithwillcode keithwillcode changed the title hotfix: add linting exception for website fix: add linting exception for website Apr 17, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) April 17, 2024 19:03
@keithwillcode keithwillcode removed the api area: API, enterprise API, access token, OAuth label Apr 17, 2024
@keithwillcode keithwillcode added this to the v4.1 milestone Apr 17, 2024
@keithwillcode keithwillcode added the High priority Created by Linear-GitHub Sync label Apr 17, 2024
Copy link

graphite-app bot commented Apr 17, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 17, 2024

Current Playwright Test Results Summary

✅ 302 Passing - ⚠️ 13 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/17/2024 07:50:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: b942870

Started: 04/17/2024 07:46:59pm UTC

⚠️ Flakes

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2Retry 1Initial Attempt
7.03% (22) 22 / 313 runs
failed over last 7 days
37.38% (117) 117 / 313 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1Initial Attempt
0.98% (3) 3 / 307 runs
failed over last 7 days
1.95% (6) 6 / 307 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 2Retry 1Initial Attempt
1% (3) 3 / 300 runs
failed over last 7 days
21.33% (64) 64 / 300 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests can add single organizer address location without display location public option
Retry 1Initial Attempt
0.33% (1) 1 / 305 run
failed over last 7 days
3.61% (11) 11 / 305 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to an organization
Retry 1Initial Attempt
0% (0) 0 / 309 runs
failed over last 7 days
6.15% (19) 19 / 309 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-0.67% (-2) -2 / 299 runs
failed over last 7 days
63.55% (190) 190 / 299 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-172.73% (-190) -190 / 110 runs
failed over last 7 days
172.73% (190) 190 / 110 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-172.73% (-190) -190 / 110 runs
failed over last 7 days
172.73% (190) 190 / 110 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-170% (-187) -187 / 110 runs
failed over last 7 days
171.82% (189) 189 / 110 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-175% (-189) -189 / 108 runs
failed over last 7 days
175% (189) 189 / 108 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-175% (-189) -189 / 108 runs
failed over last 7 days
175% (189) 189 / 108 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-175% (-189) -189 / 108 runs
failed over last 7 days
175% (189) 189 / 108 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-175% (-189) -189 / 108 runs
failed over last 7 days
175% (189) 189 / 108 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode added the api area: API, enterprise API, access token, OAuth label Apr 17, 2024
@keithwillcode keithwillcode merged commit fd58f66 into main Apr 17, 2024
37 of 39 checks passed
@keithwillcode keithwillcode deleted the hotfix/website-next-router-linting branch April 17, 2024 19:51
@PeerRich
Copy link
Member

website still blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth core area: core, team members only devops foundation High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants