feat: SMS/Whatsapp to attendee for teams #14648
Conversation
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 New Pages AddedThe following pages were added to the bundle from the code in this PR:
Seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 314 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/23/2024 07:47:51pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 3ae9a07 Started: 04/23/2024 07:45:00pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1 • Initial Attempt |
0% (0)0 / 220 runsfailed over last 7 days |
3.18% (7)7 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
7.89% (18)18 / 228 runsfailed over last 7 days |
29.39% (67)67 / 228 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 262 runsfailed over last 7 days |
8.40% (22)22 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/hash-my-url.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
hash my url generate url hash
Retry 1 • Initial Attempt |
4.88% (2)2 / 41 runsfailed over last 7 days |
24.39% (10)10 / 41 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0% (0)0 / 142 runsfailed over last 7 days |
47.89% (68)68 / 142 runsflaked over last 7 days |
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0.70% (1)1 / 142 runfailed over last 7 days |
47.18% (67)67 / 142 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 140 runsfailed over last 7 days |
47.86% (67)67 / 140 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 142 runsfailed over last 7 days |
48.59% (69)69 / 142 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
14.34% (37)37 / 258 runsfailed over last 7 days |
51.94% (134)134 / 258 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-154.02% (-134)-134 / 87 runsfailed over last 7 days |
154.02% (134)134 / 87 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-152.87% (-133)-133 / 87 runsfailed over last 7 days |
152.87% (133)133 / 87 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-150.57% (-131)-131 / 87 runsfailed over last 7 days |
151.72% (132)132 / 87 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-153.49% (-132)-132 / 86 runsfailed over last 7 days |
153.49% (132)132 / 86 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-153.49% (-132)-132 / 86 runsfailed over last 7 days |
153.49% (132)132 / 86 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-153.49% (-132)-132 / 86 runsfailed over last 7 days |
153.49% (132)132 / 86 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-153.49% (-132)-132 / 86 runsfailed over last 7 days |
153.49% (132)132 / 86 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0.77% (2)2 / 261 runsfailed over last 7 days |
8.43% (22)22 / 261 runsflaked over last 7 days |
📄 apps/web/playwright/organization/booking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
16.24% (44)44 / 271 runsfailed over last 7 days |
24.35% (66)66 / 271 runsflaked over last 7 days |
orgs can't be blocked. also not their users and teams |
| }; | ||
|
|
||
| function UsersTable({ setSMSLockState }: Props) { | ||
| const { data: usersAndTeams } = trpc.viewer.admin.getSMSLockStateTeamsUsers.useQuery(); |
There was a problem hiding this comment.
Not urgent: use infinite query here. we can probably use it later
There was a problem hiding this comment.
LGTM. works fine for me. will wait for @joeauyeung re review before merging
|
@CarinaWolli @joeauyeung @Udit-takkar why was this PR merged with 0 tests added to verify SMS locking logic? |
What does this PR do?
Before SMS/Whatsapp to attendee was only available for Orgs, now it will be available for all teams. It adds rate limit to sending SMS + an Admin view (localhost:3000/settings/admin/lockedSMS) to lock users and teams to send SMS.
Fixes #13897