Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removing away (DB related, not slot related) from code #14673

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Apr 19, 2024

What does this PR do?

👋

@graphite-app graphite-app bot requested a review from a team April 19, 2024 17:59
Copy link
Contributor

github-actions bot commented Apr 19, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Apr 19, 2024
Copy link

graphite-app bot commented Apr 19, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-starter-kit ❌ Failed (Inspect) Apr 19, 2024 6:16pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 6:16pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 6:16pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 6:16pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 19, 2024

Current Playwright Test Results Summary

✅ 310 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/19/2024 06:30:10pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7da6101

Started: 04/19/2024 06:26:57pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
6.99% (19) 19 / 272 runs
failed over last 7 days
27.57% (75) 75 / 272 runs
flaked over last 7 days

📄   apps/web/playwright/manage-booking-questions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Manage Booking Questions For Team EventType Do a booking with a user added question and verify a few thing in b/w
Retry 1Initial Attempt
3.64% (10) 10 / 275 runs
failed over last 7 days
0.36% (1) 1 / 275 run
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can add Organzer Phone Number location and book with it
Retry 1Initial Attempt
0% (0) 0 / 284 runs
failed over last 7 days
1.41% (4) 4 / 284 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1Initial Attempt
5.33% (16) 16 / 300 runs
failed over last 7 days
36.33% (109) 109 / 300 runs
flaked over last 7 days
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1Initial Attempt
7.14% (21) 21 / 294 runs
failed over last 7 days
10.20% (30) 30 / 294 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 291 runs
failed over last 7 days
43.99% (128) 128 / 291 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@emrysal emrysal merged commit a15cad4 into main Apr 20, 2024
38 of 39 checks passed
@emrysal emrysal deleted the chore/remove-away-references branch April 20, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only foundation 🧹 Improvements Improvements to existing features. Mostly UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants