fix: invalid Cancelled / Rescheduled downstream calendar block #14700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
dosubot
bot
added
bookings
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (04/22/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 310 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/22/2024 11:05:55am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e3ce933 Started: 04/22/2024 11:02:43am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity Can manage single schedule
Retry 1 • Initial Attempt |
1.29% (3)3 / 233 runsfailed over last 7 days |
24.46% (57)57 / 233 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0% (0)0 / 231 runsfailed over last 7 days |
35.06% (81)81 / 231 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
11.84% (27)27 / 228 runsfailed over last 7 days |
52.63% (120)120 / 228 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-148.15% (-120)-120 / 81 runsfailed over last 7 days |
148.15% (120)120 / 81 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-148.15% (-120)-120 / 81 runsfailed over last 7 days |
148.15% (120)120 / 81 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-145.68% (-118)-118 / 81 runsfailed over last 7 days |
146.91% (119)119 / 81 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-148.75% (-119)-119 / 80 runsfailed over last 7 days |
148.75% (119)119 / 80 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-148.75% (-119)-119 / 80 runsfailed over last 7 days |
148.75% (119)119 / 80 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-148.75% (-119)-119 / 80 runsfailed over last 7 days |
148.75% (119)119 / 80 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-148.75% (-119)-119 / 80 runsfailed over last 7 days |
148.75% (119)119 / 80 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
12.45% (29)29 / 233 runsfailed over last 7 days |
15.88% (37)37 / 233 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 88 runsfailed over last 7 days |
48.86% (43)43 / 88 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0% (0)0 / 88 runsfailed over last 7 days |
46.59% (41)41 / 88 runsflaked over last 7 days |
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
1.14% (1)1 / 88 runfailed over last 7 days |
45.45% (40)40 / 88 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 88 runsfailed over last 7 days |
48.86% (43)43 / 88 runsflaked over last 7 days |
CarinaWolli
reviewed
Apr 22, 2024
| // TODO: Reflect downstream cancellations in our Booking database and use Booking as | ||
| // source of truth. | ||
| const busyTimes = | ||
| credentials?.length > 0 |
There was a problem hiding this comment.
other non-calendar apps are also in credentials. So if there is no calendar but for example true we wouldn't get any busyTimes
There was a problem hiding this comment.
I think you're right, but it also seems to me that the input to calendarCredentials is this credentials array.. should be pre-filtered to contain only calendar credentials
| } | ||
| aggregate.push({ | ||
| start: dayjs(startTime) | ||
| .subtract((eventType?.beforeEventBuffer || 0) + (afterEventBuffer || 0), "minute") |
There was a problem hiding this comment.
Aren't we now breaking our buffers with that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Until we've got bi-directional communication; our bookings table should not generate busyTimes when external calendars are connected.