chore: Remove deprecated logo/avatar/away fields #14705

emrysal · 2024-04-22T17:00:52Z

What does this PR do?

Drops away, avatar fields from users
Drops logo field from Team

github-actions · 2024-04-22T17:01:04Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

vercel · 2024-04-22T17:02:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2024 5:09pm
platform-starter-kit	❌ Failed (Inspect)			May 20, 2024 5:09pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 5:09pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 5:09pm

graphite-app · 2024-04-22T17:05:12Z

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/22/24)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2024-04-22T17:11:31Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2024-04-22T17:12:04Z

Current Playwright Test Results Summary

✅ 315 Passing - ❌ 3 Failing - ⚠️ 9 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/20/2024 05:21:19pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 8153e72

Started: 05/20/2024 05:17:42pm UTC

❌ Failures

📄 apps/web/playwright/workflow.e2e.ts • 2 Failures

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes

Workflow Tab - Event Type Check the functionalities of the Workflow Tab User Workflows Creating a new workflow
Retry 2 • Retry 1 • Initial Attempt

Error: expect(received).toHaveCount(expected) // deep equality...

expect(received).toHaveCount(expected) // deep equality

Expected: 3
Received: 0
Call log:
  - expect.toHaveCount with timeout 30000ms
  - waiting for locator('[data-testid="workflow-list"] > li')
  -   locator resolved to 0 elements
  -   unexpected value "0"
  - waiting for locator('[data-testid="workflow-list"] > li')
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"
  -   locator resolved to 0 elements
  -   unexpected value "0"

1.18% (3)

3 / 254 runs
failed over last 7 days

0.79% (2)

2 / 254 runs
flaked over last 7 days

Workflow Tab - Event Type Check the functionalities of the Workflow Tab User Workflows Deleting an existing workflow
Retry 1 • Initial Attempt

Error: Test timeout of 60000ms exceeded.

Test timeout of 60000ms exceeded.

0.79% (2)

2 / 253 runs
failed over last 7 days

0.40% (1)

1 / 253 run
flaked over last 7 days

📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced Retry 2 • Retry 1 • Initial Attempt Error: Expected to provide an iframe, got null `Expected to provide an iframe, got null`	18.60% (48) 48 / 258 runs failed over last 7 days	34.88% (90) 90 / 258 runs flaked over last 7 days

⚠️ Flakes

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Paid booking should be able to be rescheduled Retry 1 • Initial Attempt	4.78% (11) 11 / 230 runs failed over last 7 days	16.09% (37) 37 / 230 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it Retry 2 • Retry 1 • Initial Attempt	0.40% (1) 1 / 253 run failed over last 7 days	14.23% (36) 36 / 253 runs flaked over last 7 days
Event Types tests -- future user Different Locations Tests Can remove location from multiple locations that are saved Retry 1 • Initial Attempt	3.97% (10) 10 / 252 runs failed over last 7 days	5.95% (15) 15 / 252 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

`null`	4 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace Retry 1 • Initial Attempt	0.41% (1) 1 / 243 run failed over last 7 days	62.14% (151) 151 / 243 runs flaked over last 7 days
Namespacing Different namespaces can have different init configs Retry 1 • Initial Attempt	0% (0) 0 / 241 runs failed over last 7 days	62.24% (150) 150 / 241 runs flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace) Retry 1 • Initial Attempt	0% (0) 0 / 243 runs failed over last 7 days	65.02% (158) 158 / 243 runs flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload Retry 1 • Initial Attempt	0.41% (1) 1 / 243 run failed over last 7 days	63.37% (154) 154 / 243 runs flaked over last 7 days

📄 apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can update a users email (verification enabled) Retry 1 • Initial Attempt	37.04% (100) 100 / 270 runs failed over last 7 days	34.44% (93) 93 / 270 runs flaked over last 7 days
Update Profile Can resend verification link if the secondary email is unverified Retry 1 • Initial Attempt	12.13% (33) 33 / 272 runs failed over last 7 days	30.15% (82) 82 / 272 runs flaked over last 7 days

View Detailed Build Results

zomars

CarinaWolli · 2024-04-23T19:28:26Z

Why do all e2e tests fail here? I already tried re-running them 🤔

vercel · 2024-05-02T14:47:44Z

Deployment failed with the following error:

Too many requests - try again in 1 minute (more than 60, code: "api-deployments-flood").

keithwillcode · 2024-05-06T21:58:50Z

@emrysal Looks like e2e 6/7 are failing consistently. Might need to look into it a bit more

keithwillcode

Requesting changes for this reason: #14705 (comment)

keithwillcode

@emrysal Do we need to make 2 separate PRs here?

Remove the fields from the schema
Drop the columns

Will dropping the columns before the deployment hits production start throwing errors if queries are still using the schema will these 3 fields?

chore: Remove deprecated logo/avatar/away fields

14694de

emrysal requested a review from CarinaWolli April 22, 2024 17:00

graphite-app bot requested a review from a team April 22, 2024 17:01

github-actions bot added the ❗️ migrations contains migration files label Apr 22, 2024

dosubot bot added core area: core, team members only foundation labels Apr 22, 2024

vercel bot deployed to Preview – ai April 22, 2024 17:02 View deployment

emrysal enabled auto-merge (squash) April 22, 2024 17:07

vercel bot deployed to Preview – api April 22, 2024 17:07 View deployment

vercel bot deployed to Preview – dev April 22, 2024 17:19 View deployment

CarinaWolli approved these changes Apr 22, 2024

View reviewed changes

Merge branch 'main' into chore/cleanup-deprecated-fields

9f54969

vercel bot had a problem deploying to Preview – platform-starter-kit April 23, 2024 13:25 Failure

vercel bot deployed to Preview – api April 23, 2024 13:32 View deployment

vercel bot deployed to Preview – dev April 23, 2024 13:42 View deployment

Merge branch 'main' into chore/cleanup-deprecated-fields

a999373

vercel bot had a problem deploying to Preview – platform-starter-kit April 23, 2024 17:35 Failure

vercel bot deployed to Preview – api April 23, 2024 17:41 View deployment

vercel bot deployed to Preview – dev April 23, 2024 17:54 View deployment

Merge branch 'main' into chore/cleanup-deprecated-fields

b3ac522

vercel bot had a problem deploying to Preview – platform-starter-kit April 23, 2024 18:47 Failure

zomars approved these changes Apr 23, 2024

View reviewed changes

vercel bot deployed to Preview – api April 23, 2024 18:53 View deployment

vercel bot deployed to Preview – dev April 23, 2024 19:05 View deployment

Merge branch 'main' into chore/cleanup-deprecated-fields

8201e21

vercel bot had a problem deploying to Preview – platform-starter-kit April 29, 2024 17:16 Failure

vercel bot deployed to Preview – api April 29, 2024 17:23 View deployment

vercel bot had a problem deploying to Preview – dev April 29, 2024 17:29 Failure

Merge branch 'main' into chore/cleanup-deprecated-fields

9fc1154

vercel bot had a problem deploying to Preview – platform-starter-kit April 29, 2024 17:50 Failure

vercel bot deployed to Preview – api April 29, 2024 17:57 View deployment

vercel bot had a problem deploying to Preview – dev April 29, 2024 18:02 Failure

Merge branch 'main' into chore/cleanup-deprecated-fields

88e454d

vercel bot deployed to Preview – dev May 2, 2024 15:56 View deployment

Merge branch 'main' into chore/cleanup-deprecated-fields

acd81e7

vercel bot deployed to Preview – api May 6, 2024 19:03 View deployment

vercel bot deployed to Preview – ai May 6, 2024 19:04 View deployment

vercel bot deployed to Preview – dev May 6, 2024 19:08 View deployment

keithwillcode requested changes May 7, 2024

View reviewed changes

keithwillcode added this to the v4.1 milestone May 8, 2024

Merge branch 'main' into chore/cleanup-deprecated-fields

704a9ed

vercel bot deployed to Preview – ai May 14, 2024 22:22 View deployment

vercel bot deployed to Preview – api May 14, 2024 22:26 View deployment

vercel bot deployed to Preview – dev May 14, 2024 22:32 View deployment

keithwillcode modified the milestones: v4.1, v4.2 May 15, 2024

Merge branch 'main' into chore/cleanup-deprecated-fields

8153e72

vercel bot deployed to Preview – ai May 20, 2024 17:09 View deployment

keithwillcode requested changes May 20, 2024

View reviewed changes

vercel bot deployed to Preview – api May 20, 2024 17:13 View deployment

vercel bot deployed to Preview – dev May 20, 2024 17:18 View deployment

auto-merge was automatically disabled May 23, 2024 16:50
Merge queue setting changed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove deprecated logo/avatar/away fields #14705

chore: Remove deprecated logo/avatar/away fields #14705

emrysal commented Apr 22, 2024

github-actions bot commented Apr 22, 2024 •

edited

vercel bot commented Apr 22, 2024 •

edited

graphite-app bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024 •

edited

deploysentinel bot commented Apr 22, 2024 •

edited

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

zomars left a comment

CarinaWolli commented Apr 23, 2024

vercel bot commented May 2, 2024

keithwillcode commented May 6, 2024

keithwillcode left a comment

keithwillcode left a comment

chore: Remove deprecated logo/avatar/away fields #14705

Are you sure you want to change the base?

chore: Remove deprecated logo/avatar/away fields #14705

Conversation

emrysal commented Apr 22, 2024

What does this PR do?

github-actions bot commented Apr 22, 2024 • edited

vercel bot commented Apr 22, 2024 • edited

graphite-app bot commented Apr 22, 2024

Graphite Automations

github-actions bot commented Apr 22, 2024 • edited

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented Apr 22, 2024 • edited

Current Playwright Test Results Summary

❌ Failures

Test Case Results

Test Case Results

⚠️ Flakes

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

zomars left a comment

Choose a reason for hiding this comment

CarinaWolli commented Apr 23, 2024

vercel bot commented May 2, 2024

keithwillcode commented May 6, 2024

keithwillcode left a comment

Choose a reason for hiding this comment

keithwillcode left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 22, 2024 •

edited

vercel bot commented Apr 22, 2024 •

edited

github-actions bot commented Apr 22, 2024 •

edited

deploysentinel bot commented Apr 22, 2024 •

edited