fix: Check permissions for team OOO entries #14736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zomars <zomars@me.com>
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
api
dosubot
bot
added
teams
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
zomars
commented
Apr 24, 2024
packages/trpc/server/routers/loggedInViewer/outOfOffice.handler.ts
Outdated
Show resolved
Hide resolved
zomars
commented
Apr 24, 2024
| uuid: true, | ||
| userId: true, | ||
| }, | ||
| const deletedOutOfOfficeEntry = await prisma.outOfOfficeEntry.delete({ |
There was a problem hiding this comment.
Refactored so this runs in a single query
emrysal
previously approved these changes
Apr 24, 2024
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (04/24/24)1 reviewer was added to this PR based on Keith Williams's automation. |
CarinaWolli
reviewed
Apr 24, 2024
CarinaWolli
approved these changes
Apr 24, 2024
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 52 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/24/2024 07:18:57pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5cb31bd Started: 04/24/2024 07:18:19pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
18.92% (35)35 / 185 runsfailed over last 7 days |
36.76% (68)68 / 185 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
1.14% (3)3 / 263 runsfailed over last 7 days |
10.65% (28)28 / 263 runsflaked over last 7 days |
Current Playwright Test Results Summary✅ 314 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/24/2024 07:22:24pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5cb31bd Started: 04/24/2024 07:18:19pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user enabling recurring event comes with default options
Retry 1 • Initial Attempt |
0% (0)0 / 263 runsfailed over last 7 days |
7.98% (21)21 / 263 runsflaked over last 7 days |
|
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
0.46% (1)1 / 218 runfailed over last 7 days |
27.52% (60)60 / 218 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
BOOKING_RESCHEDULED when rescheduling to a booking that already exists, should send a booking rescheduled event with the existant booking uid
Retry 2 • Retry 1 • Initial Attempt |
4.82% (11)11 / 228 runsfailed over last 7 days |
11.84% (27)27 / 228 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization
Retry 2 • Retry 1 • Initial Attempt |
0.88% (2)2 / 228 runsfailed over last 7 days |
12.28% (28)28 / 228 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule for booking with seats If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1 • Initial Attempt |
0% (0)0 / 219 runsfailed over last 7 days |
4.11% (9)9 / 219 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration When event is paid and confirmed Paid and confirmed booking should be able to be rescheduled
Retry 1 • Initial Attempt |
17.89% (44)44 / 246 runsfailed over last 7 days |
4.07% (10)10 / 246 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
9.25% (21)21 / 227 runsfailed over last 7 days |
30.84% (70)70 / 227 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt |
18.32% (50)50 / 273 runsfailed over last 7 days |
22.71% (62)62 / 273 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
16.09% (42)42 / 261 runsfailed over last 7 days |
52.49% (137)137 / 261 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-167.07% (-137)-137 / 82 runsfailed over last 7 days |
167.07% (137)137 / 82 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-165.85% (-136)-136 / 82 runsfailed over last 7 days |
165.85% (136)136 / 82 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-164.63% (-135)-135 / 82 runsfailed over last 7 days |
165.85% (136)136 / 82 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-167.90% (-136)-136 / 81 runsfailed over last 7 days |
167.90% (136)136 / 81 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-167.90% (-136)-136 / 81 runsfailed over last 7 days |
167.90% (136)136 / 81 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-167.90% (-136)-136 / 81 runsfailed over last 7 days |
167.90% (136)136 / 81 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-167.90% (-136)-136 / 81 runsfailed over last 7 days |
167.90% (136)136 / 81 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0.57% (1)1 / 176 runfailed over last 7 days |
50.57% (89)89 / 176 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0% (0)0 / 176 runsfailed over last 7 days |
51.14% (90)90 / 176 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 174 runsfailed over last 7 days |
51.15% (89)89 / 174 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 176 runsfailed over last 7 days |
51.70% (91)91 / 176 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
10.61% (28)28 / 264 runsflaked over last 7 days |
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.38% (1)1 / 262 runfailed over last 7 days |
33.21% (87)87 / 262 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
18.82% (35)35 / 186 runsfailed over last 7 days |
37.10% (69)69 / 186 runsflaked over last 7 days |
zomars
deleted the
zomars/cal-3527-security-vulnerability-create-out-of-office-and-forward
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes CAL-3527
Requirement/Documentation
Type of change
How should this be tested?
Please refer to CAL-3527 ticket in Linear
Mandatory Tasks