Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional attributes to intercom #14794

Merged
merged 4 commits into from Apr 29, 2024

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Apr 29, 2024

What does this PR do?

add additional attributes to intercom
https://app.campsite.co/cal/posts/ockp5umxb45z

Type of change

  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Apr 29, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 29, 2024

Current Playwright Test Results Summary

✅ 315 Passing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/29/2024 03:45:04pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 99a36c6

Started: 04/29/2024 03:40:49pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Login and logout tests -- legacy Login flow validations -- legacy Should warn when password is incorrect
Retry 1Initial Attempt
0% (0) 0 / 218 runs
failed over last 7 days
0.46% (1) 1 / 218 run
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_RESCHEDULED when rescheduling to a booking that already exists, should send a booking rescheduled event with the existant booking uid
Retry 1Initial Attempt
10.50% (21) 21 / 200 runs
failed over last 7 days
31.50% (63) 63 / 200 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
15.22% (35) 35 / 230 runs
failed over last 7 days
7.39% (17) 17 / 230 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 2Retry 1Initial Attempt
6.34% (13) 13 / 205 runs
failed over last 7 days
26.83% (55) 55 / 205 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- future Time slots should be reserved when selected
Retry 1Initial Attempt
0% (0) 0 / 190 runs
failed over last 7 days
8.42% (16) 16 / 190 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 1Initial Attempt
0.47% (1) 1 / 214 run
failed over last 7 days
38.32% (82) 82 / 214 runs
flaked over last 7 days
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
1.40% (3) 3 / 214 runs
failed over last 7 days
23.36% (50) 50 / 214 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 224 runs
failed over last 7 days
41.52% (93) 93 / 224 runs
flaked over last 7 days

View Detailed Build Results


Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-starter-kit ❌ Failed (Inspect) Apr 29, 2024 3:24pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 3:24pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 3:24pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 3:24pm

@SomayChauhan SomayChauhan marked this pull request as ready for review April 29, 2024 15:24
@graphite-app graphite-app bot requested a review from a team April 29, 2024 15:24
@dosubot dosubot bot added platform Anything related to our platform plan ✨ feature New feature or request labels Apr 29, 2024
@graphite-app graphite-app bot requested a review from a team April 29, 2024 15:24
Copy link

graphite-app bot commented Apr 29, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@PeerRich PeerRich merged commit 46ffeae into main Apr 29, 2024
37 of 39 checks passed
@PeerRich PeerRich deleted the add-additional-intercom-attributes branch April 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ✨ feature New feature or request platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants