chore: better logging for failed webhooks #14825
Conversation
|
|
|
@Shpadoinkle is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
dosubot
bot
added
bookings
Graphite Automations"Add community label" took an action on this PR • (05/01/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/01/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| console.error( | ||
| `Error executing webhook for event: ${eventTrigger}, URL: ${webhook.subscriberUrl}, bookingId: ${evt.bookingId}, bookingUid: ${evt.uid}`, | ||
| e | ||
| ); |
There was a problem hiding this comment.
@Shpadoinkle can you please replace this with logger?
There was a problem hiding this comment.
you can import logger from "@calcom/lib/logger";
There was a problem hiding this comment.
updated
There was a problem hiding this comment.
Requesting changes so this is blocked from merge until @Udit-takkar's requested change is implemented
Shpadoinkle
force-pushed
the
feat/better-logging-for-failed-webhooks
branch
from
70c1037
to
3792f31
Compare
Shpadoinkle
force-pushed
the
feat/better-logging-for-failed-webhooks
branch
from
3792f31
to
cab9982
Compare
Shpadoinkle
force-pushed
the
feat/better-logging-for-failed-webhooks
branch
from
cab9982
to
a6cbdb8
Compare
Shpadoinkle
force-pushed
the
feat/better-logging-for-failed-webhooks
branch
from
a6cbdb8
to
f6d3b9e
Compare
|
@keithwillcode @Udit-takkar anything else you need for this pr? |
Shpadoinkle
force-pushed
the
feat/better-logging-for-failed-webhooks
branch
from
f6d3b9e
to
9ee430d
Compare
|
@alishaz-polymath can you check if there is anything else wanted on this? |
Base branch was modified
What does this PR do?
When a webhook fails to send it's payload. Current logs aren't helpful for finding out which booking failed.
Fixes # (issue)
#13279
Requirement/Documentation
Type of change
Chore
How should this be tested?
force a webhook to fail.
Logs should shed more light on the Booking it was for
Mandatory Tasks