fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hariombalhara and the rest of your teammates on |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 322 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/22/2024 09:34:35am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: ce4bd5c Started: 05/22/2024 09:29:45am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Insights should test download button
Retry 1 • Initial Attempt |
0.46% (1)1 / 219 runfailed over last 7 days |
2.28% (5)5 / 219 runsflaked over last 7 days |
📄 apps/web/playwright/impersonation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Users can impersonate App Admin can impersonate users with impersonation enabled
Retry 2 • Retry 1 • Initial Attempt |
2.23% (5)5 / 224 runsfailed over last 7 days |
14.73% (33)33 / 224 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 227 runsfailed over last 7 days |
16.30% (37)37 / 227 runsflaked over last 7 days |
|
Event Types tests -- future user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1 • Initial Attempt |
3.98% (9)9 / 226 runsfailed over last 7 days |
5.75% (13)13 / 226 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes
Top 1 Common Error Messages
|
|
9 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
2.27% (5)5 / 220 runsfailed over last 7 days |
57.73% (127)127 / 220 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-144.32% (-127)-127 / 88 runsfailed over last 7 days |
144.32% (127)127 / 88 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-144.32% (-127)-127 / 88 runsfailed over last 7 days |
144.32% (127)127 / 88 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-143.18% (-126)-126 / 88 runsfailed over last 7 days |
144.32% (127)127 / 88 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-144.83% (-126)-126 / 87 runsfailed over last 7 days |
144.83% (126)126 / 87 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-144.83% (-126)-126 / 87 runsfailed over last 7 days |
144.83% (126)126 / 87 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-144.83% (-126)-126 / 87 runsfailed over last 7 days |
144.83% (126)126 / 87 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-144.83% (-126)-126 / 87 runsfailed over last 7 days |
144.83% (126)126 / 87 runsflaked over last 7 days |
|
Popup Tests should open on clicking child element
Retry 1 • Initial Attempt |
-142.53% (-124)-124 / 87 runsfailed over last 7 days |
142.53% (124)124 / 87 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0% (0)0 / 220 runsfailed over last 7 days |
65.45% (144)144 / 220 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0.45% (1)1 / 220 runfailed over last 7 days |
63.64% (140)140 / 220 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 220 runsfailed over last 7 days |
65.45% (144)144 / 220 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 220 runsfailed over last 7 days |
62.27% (137)137 / 220 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
3.54% (8)8 / 226 runsfailed over last 7 days |
31.86% (72)72 / 226 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
8.09% (19)19 / 235 runsfailed over last 7 days |
31.91% (75)75 / 235 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
20.33% (49)49 / 241 runsfailed over last 7 days |
35.68% (86)86 / 241 runsflaked over last 7 days |
github-actions
bot
added
High priority
hariombalhara
force-pushed
the
fix-seo-origin
branch
from
f33f0ea
to
2d97f3e
Compare
hariombalhara
force-pushed
the
fix-seo-origin
branch
from
2d97f3e
to
a0fa3c8
Compare
hariombalhara
force-pushed
the
fix-seo-origin
branch
from
a0fa3c8
to
3fc5816
Compare
dosubot
bot
added
teams
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/21/24)1 reviewer was added to this PR based on Keith Williams's automation. |
sean-brydon
reviewed
May 21, 2024
sean-brydon
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14936
Fixes CAL-3661
Fixes the origin for Cal.com used in SEO. It fixes two things automatically
Tests
Screenshots for the branch
Profile Page - Team
Profile Page - User
Event Page(BookerSeo)
For a non-org event it is same as earlier
Type of change
How should this be tested?
Mandatory Tasks