Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api v2 hotfix google calendar, exception details, billing check guard #14967

Merged
merged 1 commit into from
May 10, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

What does this PR do?

Fix: google selected calendar integration type was wrong, billing check should not fail for members, adding details to http exception filter

@graphite-app graphite-app bot requested a review from a team May 10, 2024 07:23
@ThyMinimalDev ThyMinimalDev requested review from a team and removed request for a team May 10, 2024 07:23
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels May 10, 2024
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth billing area: billing, stripe, payments, paypal, get paid 🐛 bug Something isn't working labels May 10, 2024
Copy link

graphite-app bot commented May 10, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (05/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:25am

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented May 10, 2024

Current Playwright Test Results Summary

✅ 320 Passing - ⚠️ 18 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/10/2024 07:35:50am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: e4a4831

Started: 05/10/2024 07:32:46am UTC

⚠️ Flakes

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user -- legacy Time slots should be reserved when selected
Retry 2Retry 1Initial Attempt
0% (0) 0 / 267 runs
failed over last 7 days
5.99% (16) 16 / 267 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1Initial Attempt
0% (0) 0 / 274 runs
failed over last 7 days
8.03% (22) 22 / 274 runs
flaked over last 7 days
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 2Retry 1Initial Attempt
0.36% (1) 1 / 274 run
failed over last 7 days
40.51% (111) 111 / 274 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
4.95% (14) 14 / 283 runs
failed over last 7 days
13.43% (38) 38 / 283 runs
flaked over last 7 days

📄   apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1Initial Attempt
0% (0) 0 / 274 runs
failed over last 7 days
37.23% (102) 102 / 274 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes

Top 1 Common Error Messages

null

9 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
3.64% (10) 10 / 275 runs
failed over last 7 days
56% (154) 154 / 275 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-138.74% (-154) -154 / 111 runs
failed over last 7 days
138.74% (154) 154 / 111 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-138.74% (-154) -154 / 111 runs
failed over last 7 days
138.74% (154) 154 / 111 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-136.94% (-152) -152 / 111 runs
failed over last 7 days
136.94% (152) 152 / 111 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-136.94% (-152) -152 / 111 runs
failed over last 7 days
136.94% (152) 152 / 111 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-136.94% (-152) -152 / 111 runs
failed over last 7 days
136.94% (152) 152 / 111 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-136.94% (-152) -152 / 111 runs
failed over last 7 days
136.94% (152) 152 / 111 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-136.94% (-152) -152 / 111 runs
failed over last 7 days
136.94% (152) 152 / 111 runs
flaked over last 7 days
Popup Tests should open on clicking child element
Retry 1Initial Attempt
-133.33% (-148) -148 / 111 runs
failed over last 7 days
133.33% (148) 148 / 111 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
31.19% (97) 97 / 311 runs
failed over last 7 days
34.41% (107) 107 / 311 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- legacy login flow user & logout using dashboard
Retry 1Initial Attempt
0% (0) 0 / 279 runs
failed over last 7 days
16.13% (45) 45 / 279 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1Initial Attempt
8.93% (25) 25 / 280 runs
failed over last 7 days
27.86% (78) 78 / 280 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1Initial Attempt
7.47% (21) 21 / 281 runs
failed over last 7 days
27.40% (77) 77 / 281 runs
flaked over last 7 days

View Detailed Build Results


@ThyMinimalDev ThyMinimalDev merged commit c65dca9 into main May 10, 2024
41 checks passed
@ThyMinimalDev ThyMinimalDev deleted the api-v2-hotfixes branch May 10, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth billing area: billing, stripe, payments, paypal, get paid 🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants