fix: Allow less than 30 seats for orgs #14995
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hariombalhara and the rest of your teammates on |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
hariombalhara
force-pushed
the
05-13-fix_allow_less_than_30_seats_for_orgs
branch
from
953aba5
to
8be3d4a
Compare
github-actions
bot
added
seats
hariombalhara
force-pushed
the
05-13-fix_allow_less_than_30_seats_for_orgs
branch
from
8be3d4a
to
daa5bfa
Compare
|
No failed tests 🎉 |
| }); | ||
|
|
||
| describe("purchaseTeamOrOrgSubscription", () => { | ||
| it("should use `seatsToChargeFor` to create price", async () => { |
There was a problem hiding this comment.
Added a very basic test. We can add more tests later.
| @@ -39,7 +39,10 @@ export const publishHandler = async ({ ctx }: PublishOptions) => { | |||
| if (IS_TEAM_BILLING_ENABLED) { | |||
| const checkoutSession = await purchaseTeamOrOrgSubscription({ | |||
| teamId: prevTeam.id, | |||
| seats: Math.max(prevTeam.members.length, metadata.data?.orgSeats ?? 0), | |||
| seatsUsed: prevTeam.members.length, | |||
| seatsToChargeFor: metadata.data?.orgSeats | |||
There was a problem hiding this comment.
We are supposed to directly use orgSeats, if available, for charging user.
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/13/24)1 reviewer was added to this PR based on Keith Williams's automation. |
What does this PR do?
Allowing going below 30 seats for orgs.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?