chore: more fields event-types api v2 #15031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThyMinimalDev
requested review from
keithwillcode and
supalarry
and removed request for
a team
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
dosubot
bot
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (05/14/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 321 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/14/2024 04:02:16pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5f101f0 Started: 05/14/2024 03:59:44pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load if correct embedLibUrl is provided
Retry 1 • Initial Attempt |
0% (0)0 / 257 runsfailed over last 7 days |
33.46% (86)86 / 257 runsflaked over last 7 days |
📄 apps/web/playwright/hash-my-url.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
hash my url generate url hash
Retry 1 • Initial Attempt |
5.99% (16)16 / 267 runsfailed over last 7 days |
26.97% (72)72 / 267 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user Different Locations Tests Can add Cal video location and book with it
Retry 1 • Initial Attempt |
2.19% (6)6 / 274 runsfailed over last 7 days |
4.74% (13)13 / 274 runsflaked over last 7 days |
|
Event Types tests -- legacy user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0.37% (1)1 / 273 runfailed over last 7 days |
4.76% (13)13 / 273 runsflaked over last 7 days |
📄 apps/web/playwright/workflow.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Workflow Tab - Event Type Check the functionalities of the Workflow Tab Team Workflows Admin user
Retry 1 • Initial Attempt |
0% (0)0 / 271 runsfailed over last 7 days |
1.48% (4)4 / 271 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes
Top 1 Common Error Messages
|
|
9 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.09% (3)3 / 274 runsfailed over last 7 days |
56.93% (156)156 / 274 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-135.65% (-156)-156 / 115 runsfailed over last 7 days |
135.65% (156)156 / 115 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-133.91% (-154)-154 / 115 runsfailed over last 7 days |
133.91% (154)154 / 115 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-130.43% (-150)-150 / 115 runsfailed over last 7 days |
131.30% (151)151 / 115 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-132.46% (-151)-151 / 114 runsfailed over last 7 days |
132.46% (151)151 / 114 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-132.46% (-151)-151 / 114 runsfailed over last 7 days |
132.46% (151)151 / 114 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-132.46% (-151)-151 / 114 runsfailed over last 7 days |
132.46% (151)151 / 114 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-132.46% (-151)-151 / 114 runsfailed over last 7 days |
132.46% (151)151 / 114 runsflaked over last 7 days |
|
Popup Tests should open on clicking child element
Retry 1 • Initial Attempt |
-129.20% (-146)-146 / 113 runsfailed over last 7 days |
129.20% (146)146 / 113 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 272 runsfailed over last 7 days |
59.56% (162)162 / 272 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 1 • Initial Attempt |
3.53% (3)3 / 85 runsfailed over last 7 days |
40% (34)34 / 85 runsflaked over last 7 days |
📄 apps/web/playwright/impersonation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Users can impersonate App Admin can impersonate users with impersonation enabled
Retry 1 • Initial Attempt |
0.74% (2)2 / 271 runsfailed over last 7 days |
17.34% (47)47 / 271 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1 • Initial Attempt |
3.99% (11)11 / 276 runsfailed over last 7 days |
31.88% (88)88 / 276 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 2 • Retry 1 • Initial Attempt |
14.54% (41)41 / 282 runsfailed over last 7 days |
40.78% (115)115 / 282 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Newly added secondary email should show as Unverified
Retry 2 • Retry 1 • Initial Attempt |
1.30% (4)4 / 308 runsfailed over last 7 days |
27.60% (85)85 / 308 runsflaked over last 7 days |
emrysal
approved these changes
May 14, 2024
hmm good point, the zod schema we use on web seems to not take this case into account either here: packages/prisma/zod/eventtype.ts ill make a follow up pr to change that |
|
Exactly, that's primarily why I approved it anyway but it was good to voice that concern imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Chore: api v2 allows settings more fields when creating / updating event-types