chore: Allow disabling email sending without errors #15051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
dosubot
bot
added
automated-tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (05/15/24)1 reviewer was added to this PR based on Keith Williams's automation. |
keithwillcode
approved these changes
May 15, 2024
Current Playwright Test Results Summary✅ 34 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/15/2024 02:03:15pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 1a7bf8d Started: 05/15/2024 02:02:21pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
38.32% (105)105 / 274 runsfailed over last 7 days |
33.58% (92)92 / 274 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Email sending is notoriously unreliable, so I'm working on creating a better system to test our emails that work unrelated from our general E2E suite. Our vitest tests should test that the email functions are actually called. For now however the best way forward is disabling Mailhog; but in order to disable mailhog we should prevent errors when the env var is missing. Hense this PR.