Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platform onboarding improvements #15053

Merged
merged 4 commits into from
May 16, 2024

Conversation

Ryukemeister
Copy link
Contributor

What does this PR do?

This PR adds the following things to the platform onboarding experience:

  • Skips the getting started and confirm email pages for platform users at the time of account creation
  • Add discount code option to stripe at the time of platform billing checkout
  • Platform billing cards responsiveness (4 column, then 2 column then 1 column

Copy link

linear bot commented May 15, 2024

Copy link
Contributor

github-actions bot commented May 15, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels May 15, 2024
@graphite-app graphite-app bot requested a review from a team May 15, 2024 14:05
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 2:07pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 2:07pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 2:07pm

@dosubot dosubot bot added billing area: billing, stripe, payments, paypal, get paid 🧹 Improvements Improvements to existing features. Mostly UX/UI labels May 15, 2024
Copy link

graphite-app bot commented May 15, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (05/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented May 15, 2024

Current Playwright Test Results Summary

✅ 77 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/15/2024 02:37:21pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5b72689

Started: 05/15/2024 02:36:09pm UTC

⚠️ Flakes

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Newly added secondary email should show as Unverified
Retry 2Retry 1Initial Attempt
1.79% (5) 5 / 280 runs
failed over last 7 days
27.86% (78) 78 / 280 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 1Initial Attempt
5.08% (6) 6 / 118 runs
failed over last 7 days
36.44% (43) 43 / 118 runs
flaked over last 7 days
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
0% (0) 0 / 250 runs
failed over last 7 days
2.80% (7) 7 / 250 runs
flaked over last 7 days

View Detailed Build Results


@keithwillcode keithwillcode added this to the v4.2 milestone May 15, 2024
@ThyMinimalDev ThyMinimalDev merged commit 4541f0d into main May 16, 2024
41 checks passed
@ThyMinimalDev ThyMinimalDev deleted the rajiv/cal-3700-platform-onboarding-improvements branch May 16, 2024 07:51
keithwillcode pushed a commit that referenced this pull request May 17, 2024
* allow stripe to display promo codes option

* fix layout issues for tablet devices

* redirect platform users to new platform onboarding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
billing area: billing, stripe, payments, paypal, get paid core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants