-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: org-wide workflows #15083
base: main
Are you sure you want to change the base?
feat: org-wide workflows #15083
Conversation
packages/trpc/server/routers/viewer/workflows/getAllActiveWorkflows.handler.ts
Show resolved
Hide resolved
packages/trpc/server/routers/viewer/bookings/requestReschedule.handler.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @CarinaWolli 🎉 It is a complex addition to workflows affecting a lot of places.
It was great reviewing this with your speed of iteration as well !!
I am not sure if we should merge this now or wait till after the retreat as it is a big PR.
Also, someone else who has more experience with workflows should also review this to ensure the entire functionality is working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarinaWolli can i disable global org workflow on any event type?
I see the message "Locked by team admin" even on my personal event types
org workflows can't be disabled on any event type, that's by design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work.
tested org, team and user workflows.
The only thing we can improve is to divide the large functions ( like scheduleBookingReminders) into smaller, more manageable functions.
@emrysal @zomars Just spoke with @CarinaWolli and we are going to wait until post-retreat to merge this. Moving back to draft for that reason. |
What does this PR do?
workflows/update.handler
is refactored into smaller functions that can be reused and tested.Todo:
deleteWorkfowRemindersOfRemovedMember
Follow ups:
Fixes #14638
Fixes CAL-3489
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Basic test:
Test other cases, for example:
WorkflowReminders
are correctly adjusted