Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide consumer navigation in platform admin dropdown #15117

Merged
merged 4 commits into from
May 20, 2024

Conversation

PeerRich
Copy link
Member

  • not tested yet but should work
image

@PeerRich PeerRich linked an issue May 20, 2024 that may be closed by this pull request
Copy link

linear bot commented May 20, 2024

@graphite-app graphite-app bot requested a review from a team May 20, 2024 08:12
Copy link
Contributor

github-actions bot commented May 20, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync platform Anything related to our platform plan labels May 20, 2024
@graphite-app graphite-app bot requested a review from a team May 20, 2024 08:13
@dosubot dosubot bot added the consumer label May 20, 2024
@PeerRich PeerRich removed the Medium priority Created by Linear-GitHub Sync label May 20, 2024
@PeerRich PeerRich added this to the v4.2 milestone May 20, 2024
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 10:17am
cal ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 10:17am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 10:17am

Copy link

graphite-app bot commented May 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (05/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented May 20, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 280.22 KB 508.79 KB 145.37% (🟡 +0.30%)
/apps/[slug] 297.72 KB 526.29 KB 150.37% (🟡 +0.30%)
/apps/[slug]/[...pages] 588.7 KB 817.27 KB 233.51% (🟡 +0.30%)
/apps/categories 257.95 KB 486.52 KB 139.01% (🟡 +0.30%)
/apps/categories/[category] 262.3 KB 490.87 KB 140.25% (🟡 +0.30%)
/apps/installed/[category] 281.49 KB 510.06 KB 145.73% (🟡 +0.30%)
/availability 428.94 KB 657.51 KB 187.86% (🟡 +0.30%)
/availability/[schedule] 412.69 KB 641.25 KB 183.22% (🟡 +0.30%)
/bookings/[status] 325.77 KB 554.34 KB 158.38% (🟡 +0.31%)
/enterprise 258.01 KB 486.58 KB 139.02% (🟡 +0.31%)
/event-types 557.69 KB 786.26 KB 224.64% (🟡 +0.31%)
/event-types/[type] 437.58 KB 666.15 KB 190.33% (🟡 +0.30%)
/insights 476.92 KB 705.49 KB 201.57% (🟡 +0.30%)
/more 257.52 KB 486.09 KB 138.88% (🟡 +0.30%)
/settings/admin 263.61 KB 492.18 KB 140.62% (🟡 +0.31%)
/settings/admin/apps 276.75 KB 505.31 KB 144.38% (🟡 +0.30%)
/settings/admin/apps/[category] 276.73 KB 505.3 KB 144.37% (🟡 +0.30%)
/settings/admin/flags 267.72 KB 496.29 KB 141.80% (🟡 +0.30%)
/settings/admin/impersonation 264.1 KB 492.67 KB 140.76% (🟡 +0.30%)
/settings/admin/lockedSMS 284.77 KB 513.34 KB 146.67% (🟡 +0.30%)
/settings/admin/oAuth 275.77 KB 504.34 KB 144.10% (🟡 +0.30%)
/settings/admin/orgMigrations/_OrgMigrationLayout 252.53 KB 481.09 KB 137.46% (🟡 +0.30%)
/settings/admin/orgMigrations/moveTeamToOrg 301.68 KB 530.25 KB 151.50% (🟡 +0.30%)
/settings/admin/orgMigrations/moveUserToOrg 321.08 KB 549.65 KB 157.04% (🟡 +0.31%)
/settings/admin/orgMigrations/removeTeamFromOrg 301.43 KB 529.99 KB 151.43% (🟡 +0.30%)
/settings/admin/orgMigrations/removeUserFromOrg 301.44 KB 530.01 KB 151.43% (🟡 +0.30%)
/settings/admin/organizations 265.18 KB 493.75 KB 141.07% (🟡 +0.30%)
/settings/admin/organizations/[id]/edit 264 KB 492.56 KB 140.73% (🟡 +0.31%)
/settings/admin/users 265.86 KB 494.43 KB 141.26% (🟡 +0.31%)
/settings/admin/users/[id]/edit 394.54 KB 623.11 KB 178.03% (🟡 +0.30%)
/settings/admin/users/add 394.27 KB 622.84 KB 177.95% (🟡 +0.31%)
/settings/billing 263.72 KB 492.28 KB 140.65% (🟡 +0.31%)
/settings/developer/api-keys 267.77 KB 496.34 KB 141.81% (🟡 +0.30%)
/settings/developer/webhooks 267.87 KB 496.43 KB 141.84% (🟡 +0.30%)
/settings/developer/webhooks/[id] 268.86 KB 497.43 KB 142.12% (🟡 +0.31%)
/settings/developer/webhooks/new 268.86 KB 497.43 KB 142.12% (🟡 +0.31%)
/settings/my-account/appearance 316.57 KB 545.14 KB 155.75% (🟡 +0.31%)
/settings/my-account/calendars 274.29 KB 502.86 KB 143.67% (🟡 +0.31%)
/settings/my-account/conferencing 275.56 KB 504.13 KB 144.04% (🟡 +0.30%)
/settings/my-account/general 379.49 KB 608.06 KB 173.73% (🟡 +0.30%)
/settings/my-account/out-of-office 268.39 KB 496.96 KB 141.99% (🟡 +0.30%)
/settings/my-account/profile 407.04 KB 635.6 KB 181.60% (🟡 +0.30%)
/settings/organizations/admin-api 263.62 KB 492.19 KB 140.62% (🟡 +0.31%)
/settings/organizations/appearance 287.67 KB 516.24 KB 147.50% (🟡 +0.30%)
/settings/organizations/billing 263.8 KB 492.37 KB 140.68% (🟡 +0.30%)
/settings/organizations/dsync 295.9 KB 524.47 KB 149.85% (🟡 +0.30%)
/settings/organizations/general 351.47 KB 580.04 KB 165.72% (🟡 +0.31%)
/settings/organizations/members 401.25 KB 629.82 KB 179.95% (🟡 +0.30%)
/settings/organizations/privacy 269.38 KB 497.95 KB 142.27% (🟡 +0.30%)
/settings/organizations/profile 399.79 KB 628.36 KB 179.53% (🟡 +0.30%)
/settings/organizations/sso 274.46 KB 503.03 KB 143.72% (🟡 +0.31%)
/settings/organizations/teams/other 264.37 KB 492.94 KB 140.84% (🟡 +0.30%)
/settings/organizations/teams/other/[id]/appearance 276.51 KB 505.08 KB 144.31% (🟡 +0.30%)
/settings/organizations/teams/other/[id]/members 271.46 KB 500.03 KB 142.86% (🟡 +0.31%)
/settings/organizations/teams/other/[id]/profile 470.6 KB 699.17 KB 199.76% (🟡 +0.31%)
/settings/security/impersonation 268.62 KB 497.19 KB 142.05% (🟡 +0.31%)
/settings/security/password 306.19 KB 534.75 KB 152.79% (🟡 +0.30%)
/settings/security/sso 273.79 KB 502.36 KB 143.53% (🟡 +0.30%)
/settings/security/two-factor-auth 272.05 KB 500.62 KB 143.03% (🟡 +0.31%)
/settings/teams 263.28 KB 491.85 KB 140.53% (🟡 +0.30%)
/settings/teams/[id]/appearance 276.49 KB 505.06 KB 144.30% (🟡 +0.31%)
/settings/teams/[id]/billing 263.8 KB 492.36 KB 140.68% (🟡 +0.30%)
/settings/teams/[id]/members 381.49 KB 610.06 KB 174.30% (🟡 +0.31%)
/settings/teams/[id]/profile 471.44 KB 700 KB 200.00% (🟡 +0.30%)
/teams 257.74 KB 486.31 KB 138.95% (🟡 +0.30%)
/upgrade 257.87 KB 486.43 KB 138.98% (🟡 +0.30%)
/workflows 289.21 KB 517.78 KB 147.94% (🟡 +0.30%)
/workflows/[workflow] 411.63 KB 640.2 KB 182.91% (🟡 +0.31%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions github-actions bot added the Medium priority Created by Linear-GitHub Sync label May 20, 2024
Copy link
Contributor

@Ryukemeister Ryukemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything works as expected

Copy link

deploysentinel bot commented May 20, 2024

Current Playwright Test Results Summary

✅ 46 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/20/2024 10:43:40am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f272b43

Started: 05/20/2024 10:42:48am UTC

⚠️ Flakes

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 1Initial Attempt
4.55% (10) 10 / 220 runs
failed over last 7 days
31.82% (70) 70 / 220 runs
flaked over last 7 days

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1Initial Attempt
19.17% (46) 46 / 240 runs
failed over last 7 days
34.58% (83) 83 / 240 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 1Initial Attempt
8.75% (21) 21 / 240 runs
failed over last 7 days
25% (60) 60 / 240 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal merged commit 5c2d2de into main May 20, 2024
40 of 41 checks passed
@emrysal emrysal deleted the 14976-cal-3678-platform-dropdown branch May 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer Medium priority Created by Linear-GitHub Sync platform Anything related to our platform plan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3678] platform dropdown
3 participants