-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add get recording and transcripts API endpoint #15131
Conversation
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
/** | ||
* @swagger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added swagger configuration
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/21/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Current Playwright Test Results Summary✅ 321 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/22/2024 10:51:13am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: cb866ad Started: 05/22/2024 10:47:53am UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1 • Initial Attempt |
3.36% (8)8 / 238 runsfailed over last 7 days |
11.34% (27)27 / 238 runsflaked over last 7 days |
📄 apps/web/playwright/hash-my-url.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
hash my url generate url hash
Retry 2 • Retry 1 • Initial Attempt |
7.24% (16)16 / 221 runsfailed over last 7 days |
28.05% (62)62 / 221 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0.45% (1)1 / 222 runfailed over last 7 days |
11.26% (25)25 / 222 runsflaked over last 7 days |
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.45% (1)1 / 221 runfailed over last 7 days |
31.22% (69)69 / 221 runsflaked over last 7 days |
📄 apps/web/playwright/impersonation.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Users can impersonate App Admin can impersonate users with impersonation enabled
Retry 1 • Initial Attempt |
2.21% (5)5 / 226 runsfailed over last 7 days |
15.04% (34)34 / 226 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
4 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0.45% (1)1 / 223 runfailed over last 7 days |
63.68% (142)142 / 223 runsflaked over last 7 days |
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 223 runsfailed over last 7 days |
65.47% (146)146 / 223 runsflaked over last 7 days |
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 223 runsfailed over last 7 days |
62.33% (139)139 / 223 runsflaked over last 7 days |
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0% (0)0 / 223 runsfailed over last 7 days |
65.47% (146)146 / 223 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Update Profile Can verify the newly added secondary email
Retry 1 • Initial Attempt |
2.65% (7)7 / 264 runsfailed over last 7 days |
21.21% (56)56 / 264 runsflaked over last 7 days |
@Udit-takkar None of the mandatory tasks are checked. Were you planning on doing them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and clean. I love it. Some basic unit tests would be nice tho. You can use the ones at apps/api/v1/test/lib/event-types/[id]/_get.test.ts
as reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the new tests from my perspective :)
* feat: add get recording API endpoint * feat: add transcript endpoint * chore: add missing await * chore: add error handling * fix: type err and add swagger comment * test: add test * chore: add afterEach * fix: test * test: add transcript test
What does this PR do?
TODO:
Mandatory Tasks (DO NOT REMOVE)