fix: Adds missing dependecy #15139
Merged
fix: Adds missing dependecy #15139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
High priority
zomars
commented
May 20, 2024
| @@ -34,6 +34,7 @@ | |||
| "@calcom/embed-snippet": "workspace:*", | |||
| "@calcom/features": "*", | |||
| "@calcom/lib": "*", | |||
| "@calcom/platform-types": "*", | |||
There was a problem hiding this comment.
Turbo repo already builds dependencies before building web. And since we're importing types in apps/web, we need to set a explicit dependency here.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (05/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
keithwillcode
approved these changes
May 20, 2024
Current Playwright Test Results Summary✅ 34 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/21/2024 01:03:44am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2cedd87 Started: 05/21/2024 01:02:39am UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
39.17% (94)94 / 240 runsfailed over last 7 days |
32.50% (78)78 / 240 runsflaked over last 7 days |
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
11.16% (27)27 / 242 runsfailed over last 7 days |
31.40% (76)76 / 242 runsflaked over last 7 days |
…m-types-when-freshly-building
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/md5@2.3.0, npm/rrule@2.8.1, npm/superjson@1.9.1 |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
zomars
deleted the
zomars/cal-3768-missing-module-calcomplatform-types-when-freshly-building
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes error when trying to build on a fresh install:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?