Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failing futureLimit handleNewBooking test #15155

Merged
merged 1 commit into from
May 22, 2024

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented May 22, 2024

What does this PR do?

  • Re-enables skipped booking-limit test for Future Limit
  • Fixes the test.
  • Mark getDate deprecated and suggest a better way.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

Copy link
Contributor

github-actions bot commented May 22, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite Graphite

@keithwillcode keithwillcode added consumer core area: core, team members only labels May 22, 2024
@hariombalhara hariombalhara changed the title Fix test fix: Failing futureLimit handleNewBooking test May 22, 2024
@hariombalhara hariombalhara self-assigned this May 22, 2024
@hariombalhara hariombalhara requested a review from zomars May 22, 2024 08:56
@hariombalhara hariombalhara marked this pull request as ready for review May 22, 2024 08:56
@graphite-app graphite-app bot requested a review from a team May 22, 2024 08:57
@dosubot dosubot bot added automated-tests area: unit tests, e2e tests, playwright bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels May 22, 2024
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

graphite-app bot commented May 22, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/22/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode added this to the v4.2 milestone May 22, 2024
Copy link

deploysentinel bot commented May 22, 2024

Current Playwright Test Results Summary

✅ 321 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/22/2024 09:10:57am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: fefb4dd

Started: 05/22/2024 09:06:14am UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
2.84% (6) 6 / 211 runs
failed over last 7 days
16.11% (34) 34 / 211 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1Initial Attempt
0% (0) 0 / 224 runs
failed over last 7 days
6.70% (15) 15 / 224 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 1Initial Attempt
33.85% (88) 88 / 260 runs
failed over last 7 days
35.77% (93) 93 / 260 runs
flaked over last 7 days
Update Profile Newly added secondary email should show as Unverified
Retry 1Initial Attempt
1.92% (5) 5 / 261 runs
failed over last 7 days
21.07% (55) 55 / 261 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to a team inside organization
Retry 1Initial Attempt
0.46% (1) 1 / 219 run
failed over last 7 days
6.85% (15) 15 / 219 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 1Initial Attempt
3.56% (8) 8 / 225 runs
failed over last 7 days
31.56% (71) 71 / 225 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load if correct embedLibUrl is provided
Retry 1Initial Attempt
0% (0) 0 / 215 runs
failed over last 7 days
31.63% (68) 68 / 215 runs
flaked over last 7 days

View Detailed Build Results


@hariombalhara hariombalhara merged commit 4217efc into main May 22, 2024
45 of 46 checks passed
@hariombalhara hariombalhara deleted the add-back-future-limit-handleNewBooking-test branch May 22, 2024 09:14
@zomars zomars mentioned this pull request May 22, 2024
3 tasks
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants