fix: typo in Gcal atom prop and outlook service
#15319
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rajiv Sahal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
dosubot
bot
added
api
Ryukemeister
commented
Jun 4, 2024
| @@ -156,7 +156,7 @@ export class OutlookService implements OAuthCalendarApp { | |||
|
|
|||
| const office365OAuthCredentials = await this.getOAuthCredentials(parsedCode); | |||
|
|
|||
| const defaultCalendar = await this.getDefaultCalendar(accessToken); | |||
| const defaultCalendar = await this.getDefaultCalendar(office365OAuthCredentials.access_token); | |||
There was a problem hiding this comment.
Here we need to pass in the access token for the users office365 oauth credentials.
Graphite Automations"Add platform team as reviewer" took an action on this PR • (06/04/24)1 reviewer was added to this PR based on Keith Williams's automation. |
3 tasks
ThyMinimalDev
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
OnCheckErroTypetoOnCheckErrorType2. And inside of the calendars service while trying to get the default calendar of a user we were passing the access token of our v2 api instead of passing the access token that we get from a users outlook credentials. This was resulting in an invalid and as a result user credentials were not being saved in the db.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This can be tested under the examples app in
packages/platform/examples/base