Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed next app dir banner #15356

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

PeerRich
Copy link
Member

@PeerRich PeerRich commented Jun 6, 2024

image

why removing?

  • it never worked (404, due to not fully implemented)
  • it's annoying
  • i record a lot of videos with my account and i always have to hide it with chrome inspector or adblock (causin other issues)

after removing:

we can just visit the URL when its working: https://app.cal.com/api/future-opt-in

@PeerRich PeerRich linked an issue Jun 6, 2024 that may be closed by this pull request
@graphite-app graphite-app bot requested review from a team June 6, 2024 14:59
@github-actions github-actions bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

graphite-app bot commented Jun 6, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (06/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/06/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:07pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 3:07pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 3:07pm

@keithwillcode keithwillcode added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit f6930df Jun 6, 2024
24 checks passed
@keithwillcode keithwillcode deleted the 15355-hide-app-dir-banner branch June 6, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3879] hide app dir banner
2 participants