Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event type uses calvideo as location instead of user default #15442

Conversation

Shaik-Sirajuddin
Copy link
Contributor

What does this PR do?

Screencast.from.15-06-24.10.49.59.PM.IST.webm

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • Set default conferencing app as googlemeet or any other
  • Create an event type via homepage
  • Check the location of created event type
  • The location will correspond to the default app in settings

Checklist

Copy link

vercel bot commented Jun 15, 2024

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 15, 2024
@graphite-app graphite-app bot requested a review from a team June 15, 2024 17:26
@github-actions github-actions bot added event-types area: event types, event-types 🐛 bug Something isn't working labels Jun 15, 2024
Copy link

graphite-app bot commented Jun 15, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/15/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and it works - would you be up for extracting this util function and writing a unit test around it so we don't run into edge cases like this in the future?

@Shaik-Sirajuddin
Copy link
Contributor Author

Shaik-Sirajuddin commented Jun 18, 2024

I have tested this and it works - would you be up for extracting this util function and writing a unit test around it so we don't run into edge cases like this in the future?

Added tests and made changes as suggested
PTAL @sean-brydon

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding tests <3

@keithwillcode keithwillcode added this to the v4.4 milestone Jun 19, 2024
@CarinaWolli CarinaWolli added this pull request to the merge queue Jun 19, 2024
Merged via the queue into calcom:main with commit 762b995 Jun 19, 2024
16 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync event-types area: event types, event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event type is created with calvideo instead of user default conferencing app
4 participants