-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: event type uses calvideo as location instead of user default #15442
fix: event type uses calvideo as location instead of user default #15442
Conversation
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add community label" took an action on this PR • (06/15/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/15/24)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this and it works - would you be up for extracting this util function and writing a unit test around it so we don't run into edge cases like this in the future?
Added tests and made changes as suggested |
…ault_conferencing_app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for adding tests <3
What does this PR do?
Screencast.from.15-06-24.10.49.59.PM.IST.webm
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist