Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Webex app not working #15485

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Recording.2024-06-19.134821.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

@graphite-app graphite-app bot requested a review from a team June 19, 2024 08:22
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 19, 2024
Copy link

vercel bot commented Jun 19, 2024

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working labels Jun 19, 2024
Copy link

graphite-app bot commented Jun 19, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/19/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode added the High priority Created by Linear-GitHub Sync label Jun 19, 2024
@keithwillcode keithwillcode added this to the v4.3 milestone Jun 19, 2024
Copy link
Member

@SomayChauhan SomayChauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work as always @Amit91848
can you confirm that adding webex as a location in events and booking it generates a link. I tried but for me it is throwing error, could be I have the scopes set up wrong

Screenshot 2024-06-21 at 9 31 14 PM

Screenshot 2024-06-21 at 9 30 34 PM

Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested and worked fine

@Udit-takkar Udit-takkar added this pull request to the merge queue Jun 21, 2024
@Amit91848
Copy link
Contributor Author

Great Work as always @Amit91848 can you confirm that adding webex as a location in events and booking it generates a link. I tried but for me it is throwing error, could be I have the scopes set up wrong

Screenshot 2024-06-21 at 9 31 14 PM

Screenshot 2024-06-21 at 9 30 34 PM

Hey @Udit-takkar
I was trying this locally and am facing the same issue. Does this work for you?

Merged via the queue into calcom:main with commit 10f8b40 Jun 21, 2024
15 of 22 checks passed
@Udit-takkar
Copy link
Contributor

@Amit91848 Yeah it worked fine for me.

Screenshot 2024-06-22 at 12 35 27 AM

@Udit-takkar
Copy link
Contributor

@SomayChauhan did you add the client ID and Client secret in admin settings > apps in cal.com ?

@Amit91848
Copy link
Contributor Author

Amit91848 commented Jun 21, 2024

@Amit91848 Yeah it worked fine for me.

Screenshot 2024-06-22 at 12 35 27 AM

I did some digging and found out that only spark:kms scope was being set for me. Maybe it was some setup issue from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3823] Webex app not working
4 participants