fix: AvailabilitySettings atom closing override window button #15518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
dosubot
bot
added
i18n
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
ThyMinimalDev
previously approved these changes
Jun 21, 2024
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/21/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (06/21/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
Don't know why is unit test failing - the Close button is appearing in the web app 
|
Updated test in fix: test - I guess that the test does not load i18n files but takes the string passed to the "t" function inferring i18n value literally. |
ThyMinimalDev
approved these changes
Jun 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
p6l-richard
pushed a commit
to p6l-richard/cal.com-fork
that referenced
this pull request
Jul 22, 2024
…#15518) * fix: close override window button * fix: test
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When adding date override in availability atom there is no "Close" button like in web app.
Reason
If you see file changed, then before we displayed "Close" text as
t("Close")}, but no such entry exists in our i18n files only "close":Solution
Change
t("Close")}tot("close")}and override close button is showing: