fix: reduce cal recording bitrate #15588
Conversation
github-actions
bot
added
cal video
Medium priority
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
| @@ -165,3 +165,11 @@ export const TRANSCRIPTION_STARTED_ICON = IS_PRODUCTION | |||
| export const TRANSCRIPTION_STOPPED_ICON = IS_PRODUCTION | |||
| ? `${WEBAPP_URL}/sparkles.svg` | |||
| : `https://app.cal.com/sparkles.svg`; | |||
|
|
|||
| export const RECORDING_DEFAULT_ICON = IS_PRODUCTION | |||
There was a problem hiding this comment.
Daily requires icon to be in https format so this won't be visible right now locally.
| import { z } from "zod"; | ||
|
|
||
| /** @link https://docs.daily.co/reference/rest-api/rooms/create-room */ | ||
| export const dailyReturnTypeSchema = z.object({ |
There was a problem hiding this comment.
just moved zod schemas to this file
| room_name: dailyEvent.name, | ||
| exp: dailyEvent.config.exp, | ||
| is_owner: true, | ||
| enable_recording_ui: false, |
There was a problem hiding this comment.
set enable_recording_ui: false to hide default recording button because we want are using customTrayButtons
| recording: { | ||
| label: "Record", | ||
| tooltip: "Start or stop recording", | ||
| iconPath: RECORDING_DEFAULT_ICON, | ||
| iconPathDarkMode: RECORDING_DEFAULT_ICON, | ||
| }, |
There was a problem hiding this comment.
Custom Recording button
| const guestMeetingPassword = await generateGuestMeetingTokenFromOwnerMeetingToken( | ||
| videoReference.meetingPassword | ||
| ); |
There was a problem hiding this comment.
This is required because we want a meeting token with enable_recording_ui: false so that default recording button doesn't show up
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/27/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/27/24)1 reviewer was added to this PR based on Keith Williams's automation. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
What does this PR do?
Slack thread about implementation https://calcominc.slack.com/archives/C02EQ5KP630/p1718760508623649?thread_ts=1718307301.750959&cid=C02EQ5KP630
TODO:-
AFTER(21s, 480p, 500KB) VS BEFORE(26s, 1080p, 15MB)
Mandatory Tasks (DO NOT REMOVE)