refactor: move functions to separate files #15590
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/26/24)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
bookings
| import { credentialForCalendarServiceSelect } from "@calcom/prisma/selects/credential"; | ||
| import { EventTypeMetaDataSchema, customInputSchema } from "@calcom/prisma/zod-utils"; | ||
|
|
||
| export const getEventTypesFromDB = async (eventTypeId: number) => { |
There was a problem hiding this comment.
No change in the code here
| paymentAppData: PaymentAppData; | ||
| originalRescheduledBookingOrganizerId: number | undefined; | ||
| }) { | ||
| const requiresConfirmation = determineRequiresConfirmation(eventType, bookingStartTime); |
There was a problem hiding this comment.
created smaller functions
| eventTypeCustomInputs.forEach((etcInput) => { | ||
| if (etcInput.required) { | ||
| const input = reqCustomInputs.find((input) => input.label === etcInput.label); | ||
| validateInput(etcInput, input?.value); |
There was a problem hiding this comment.
moved the logic to validateInput
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Twenty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
What does this PR do?
Continuing refactor of handleNewBooking
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?