Fix signup query

[miguelnietoa]

What does this PR do?

This PR modifies the query to check if there is an existing user, removing the condition that the email must be verified and adding ones that check if both password and username are set. The condition of email verified is not necessary because even if the email is not verified the user exists and has access to create event types, bookings, teams, etc.

Some tests were also added.

Fixes #1432

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• Go to a team page (/settings/teams)
• Invite a new user (without an account yet)
• Click the link on the invite email or if running locally: visit directly the URL /auth/signun?token={token}. The token can be found in the VerificationRequest table.
• Try to signup with an unavailable username
• The error message should be Username already taken

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code and corrected any misspellings
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[vercel]

@miguelnietoa is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[zomars]

Nice work! Everything looks fine from my side. I'm tagging @jamiepine since he's working in a team settings refactor.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cal/calendso/8rvMAkEgqqKoGb6yUXZJs4PBCX9V
✅ Preview: https://calendso-git-fork-kommitters-fix-signup-query-cal.vercel.app

[miguelnietoa]

Nice work! Everything looks fine from my side. I'm tagging @jamiepine since he's working in a team settings refactor.

All right @zomars , thanks. 💯

[zomars]

BTW @miguelnietoa there are some conflicts with main that must be resolved first. Also there is one test failing. If we could check those out before merging that would be awesome. 🙏🏽

[miguelnietoa]

BTW @miguelnietoa there are some conflicts with main that must be resolved first. Also there is one test failing. If we could check those out before merging that would be awesome. 🙏🏽

Both required changes are done! 👍🏻 @zomars
I just had to delete from the database all the data created for the tests I did because the Button with data-testid="new-event-type" is only shown when the user has no teams, that's why the test playwright/event-types.test.ts failed.
But now all works well.

Best.

[zomars]

Thank you for your contribution! I'll merge once all checks passes.

[zomars]

@miguelnietoa we just need to update the branch to main and we're good to go! 👍🏽

[miguelnietoa]

Thanks @zomars 🚀