Ignores e2e test for translation PRs #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cal/calendso/9trLj29UcDnbSYboGyDjuiFCPpVv |
baileypumfleet
approved these changes
Feb 8, 2022
we should change all tests to use aria or id vs actual text |
zomars
added a commit
that referenced
this pull request
Feb 15, 2022
buschco
pushed a commit
to buschco/calendso
that referenced
this pull request
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ignores e2e test for translation PRs. The only drawback from this it that an unexpected change for the English strings COULD break e2e test since some tests depends on the displayed text on buttons. Ex: "Create event type" etc.
Type of change