Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fallback if name is null #2157

Merged
merged 1 commit into from Mar 15, 2022
Merged

Add a fallback if name is null #2157

merged 1 commit into from Mar 15, 2022

Conversation

baileypumfleet
Copy link
Contributor

Null shows in the URL if name is null, so this adds an OR to show the username instead

@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/3MgeLiq2QsdKLGBpkLQb6T4yS9wn
✅ Preview: Canceled

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/3fcaEwQksdMoWniDbWrDFvkh673Y
✅ Preview: https://calendso-git-name-fallback-cal.vercel.app

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baileypumfleet baileypumfleet merged commit fae714b into main Mar 15, 2022
@baileypumfleet baileypumfleet deleted the name-fallback branch March 15, 2022 15:43
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants