Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Email Notes #2356

Merged
merged 4 commits into from Apr 3, 2022
Merged

Fix - Email Notes #2356

merged 4 commits into from Apr 3, 2022

Conversation

sean-brydon
Copy link
Member

What does this PR do?

Currently if you select the option to hide notes. The only way to view them notes is by logging into the app.
It has been requested that the notes still show in the email invitations.

CleanShot 2022-04-02 at 17 14 46

CleanShot 2022-04-02 at 17 14 55

Fixes # (issue)

Type of change

How should this be tested?

  • Enable hide notes
  • Create a booking
  • Check calendar - notes hidden
  • However, email invitation should display notes
  • [ ]

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Apr 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/Ek3oxHRyuHuWZXzXYWa9zbm7m4xP
✅ Preview: Canceled

[Deployment for ed0dcfb canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/2SGWtvzvtqKKwJyC5EvUcsrRLDHU
✅ Preview: https://calendso-git-bug-email-hidden-notes-cal.vercel.app

@@ -530,6 +529,9 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse)
if (rescheduleUid) {
// Use EventManager to conditionally use all needed integrations.
const updateManager = await eventManager.update(evt, rescheduleUid);
// This gets overridden when updating the event - to check if notes have been hidden or not. We just reset this back
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note at this point it has already been created in prisma with the right values

@vercel vercel bot temporarily deployed to Preview – docs April 2, 2022 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso April 2, 2022 16:31 Inactive
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but final approval pending from @zomars

@vercel vercel bot temporarily deployed to Preview – calendso April 3, 2022 08:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs April 3, 2022 08:17 Inactive
@sean-brydon sean-brydon requested a review from zomars April 3, 2022 15:41
@vercel vercel bot temporarily deployed to Preview – calendso April 3, 2022 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs April 3, 2022 16:41 Inactive
@zomars zomars merged commit 95aa5fe into main Apr 3, 2022
@zomars zomars deleted the bug/email-hidden-notes branch April 3, 2022 17:59
joeauyeung added a commit that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants