Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E Tests and Fix broken success page and non existing user URL #2411

Merged
merged 2 commits into from Apr 7, 2022
Merged

Fix E2E Tests and Fix broken success page and non existing user URL #2411

merged 2 commits into from Apr 7, 2022

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Apr 7, 2022 •
edited

What does this PR do?

  • Fixes Tests Timing out
  • Fixes the issue where if the user isn't logged in and he books a dynamic meeting link and reaches the success page which gives 500. [Try booking pro+free when you are logged out.]
  • User tries to access a non-existing user's cal link - https://cal.com/abc/2 (Gives 500)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Tests Fix

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Apr 7, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/EQjfJFa9uPE3c46hptEfQ9nKykcQ
✅ Preview: Canceled

[Deployment for 1ffb7e1 canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/CCWPc5s8ZWcsd7b6dkB4Hj32GnC9
✅ Preview: https://calendso-git-fix-playwright-tests-cal.vercel.app

@vercel vercel bot temporarily deployed to Preview – calendso April 7, 2022 04:19 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso April 7, 2022 05:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs April 7, 2022 05:43 Inactive
@hariombalhara hariombalhara changed the title Add test file Fix E2E Tests and Fix broken success page and non existing user URL Apr 7, 2022
@hariombalhara hariombalhara marked this pull request as ready for review April 7, 2022 06:00
@vercel vercel bot temporarily deployed to Preview – docs April 7, 2022 06:01 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso April 7, 2022 06:01 Inactive
baileypumfleet
baileypumfleet approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@baileypumfleet baileypumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will be great to get e2e more stable

@baileypumfleet baileypumfleet merged commit 31a8f25 into main Apr 7, 2022
@baileypumfleet baileypumfleet deleted the fix/playwright-tests branch April 7, 2022 07:34
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileypumfleet baileypumfleet baileypumfleet approved these changes

@zomars zomars Awaiting requested review from zomars

@alishaz-polymath alishaz-polymath Awaiting requested review from alishaz-polymath

Assignees
No one assigned
Labels
core area: core, team members only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hariombalhara @baileypumfleet @PeerRich