Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass recurring count value #3844

Merged
merged 6 commits into from
Aug 27, 2022
Merged

fix: pass recurring count value #3844

merged 6 commits into from
Aug 27, 2022

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Aug 14, 2022 •
edited

Fixes: #3803

Screenshot 2022-08-14 at 11 44 30 PM

Screen.Recording.2022-08-15.at.12.51.09.AM.mov

@vercel
Copy link

vercel bot commented Aug 14, 2022

@Udit-takkar is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@Udit-takkar Udit-takkar marked this pull request as draft August 14, 2022 18:14
@Udit-takkar Udit-takkar marked this pull request as ready for review August 14, 2022 18:25
@Udit-takkar
Copy link
Contributor Author

Udit-takkar commented Aug 14, 2022 •
edited

1st and 3rd bug reported in issue have been fixed

cc @CarinaWolli

@Udit-takkar Udit-takkar marked this pull request as draft August 14, 2022 18:33
@Udit-takkar Udit-takkar marked this pull request as ready for review August 17, 2022 15:29
@PeerRich PeerRich requested a review from leog August 24, 2022 08:29
leog
leog approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@leog leog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Udit-takkar for your contribution. It seems it has the correct behavior with your changes so approving.

@vercel
Copy link

vercel bot commented Aug 25, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 2:11PM (UTC)

@Udit-takkar
Copy link
Contributor Author

Thanks for reviewing @leog

@Udit-takkar
Copy link
Contributor Author

@leog are there any blockers for merging this PR?

@leog
Copy link
Contributor

leog commented Aug 26, 2022

@leog are there any blockers for merging this PR?

Not really. I don’t usually merge other developer’s PRs, that’s all ☺️ Unless you can’t merge it, go ahead, otherwise let me know and I can do it. Thanks again for your contributions, really appreciated.

@Udit-takkar
Copy link
Contributor Author

@leog i don't have permission to merge. So you would have to do it.

@leog leog merged commit 944f4dc into calcom:main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leog leog leog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cal.com Core Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with number of occurrences of recurring events
3 participants
@Udit-takkar @leog @PeerRich