Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppsTab UX + fixes warptext on horizontal tabs #3966

Merged
merged 3 commits into from
Aug 26, 2022
Merged

AppsTab UX + fixes warptext on horizontal tabs #3966

merged 3 commits into from
Aug 26, 2022

Conversation

sean-brydon
Copy link
Member

What does this PR do?

Fixes no apps being installed + fixed the horizontal tab from warping on mobile

CleanShot 2022-08-25 at 14 03 19

@vercel
Copy link

vercel bot commented Aug 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 9:52AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
swagger ⬜️ Ignored (Inspect) Aug 26, 2022 at 9:52AM (UTC)

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all fine after the eslint errors are fixed 👍

Icon={Icon.FiGrid}
headline={t("empty_installed_apps_headline")}
description={t("empty_installed_apps_description")}
buttonRaw={<Button href="/apps">{t("empty_installed_apps_button")} </Button>}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if we save event type settings here before routing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will pick this up in a separate PR cause I agree :) - modal popop warning the user too

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @sean-brydon 🙏🏽

@zomars zomars merged commit 090a977 into main Aug 26, 2022
@zomars zomars deleted the V2-AppTabUX branch August 26, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants