-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppsTab UX + fixes warptext on horizontal tabs #3966
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be all fine after the eslint errors are fixed 👍
Icon={Icon.FiGrid} | ||
headline={t("empty_installed_apps_headline")} | ||
description={t("empty_installed_apps_description")} | ||
buttonRaw={<Button href="/apps">{t("empty_installed_apps_button")} </Button>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice if we save event type settings here before routing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will pick this up in a separate PR cause I agree :) - modal popop warning the user too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @sean-brydon 🙏🏽
What does this PR do?
Fixes no apps being installed + fixed the horizontal tab from warping on mobile