Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 3976/fix label #3992

Merged
merged 5 commits into from
Aug 26, 2022
Merged

Conversation

edgarallanglez
Copy link

What does this PR do?

This change improved the label text in Apple Calendar setup to be more clear; username was changed to Apple ID for a better user experience.

image

Fixes #3976

Environment: Staging(main branch)

Type of change

How should this be tested?

Navigate to /apps/apple-calendar/setup

@vercel
Copy link

vercel bot commented Aug 26, 2022

@edgarallanglez is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@zomars zomars requested a review from alannnc August 26, 2022 21:57
Copy link
Contributor

@alannnc alannnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel
Copy link

vercel bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 11:00PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
swagger ⬜️ Ignored (Inspect) Aug 26, 2022 at 11:00PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix/credential-details-apple-calendar-setup
3 participants