Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation category and move zapier and n8n to it #4410

Merged
merged 7 commits into from Sep 15, 2022

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Sep 13, 2022

What does this PR do?

Fixes # (issue)

  • Adds automation category
  • Moves Zapier and n8n to automation category

Loom Demo

Environment: Production

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Go and check that there there are 2 Apps shown under automation on Apps home page.
  • Go to automation category and see that the 2 apps are n8n and Zapier

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 8:14AM (UTC)

@hariombalhara hariombalhara requested review from zomars and PeerRich and removed request for zomars September 13, 2022 03:56
@hariombalhara hariombalhara changed the title Add automation category Add automation category and move zapier and n8n to it Sep 13, 2022
@hariombalhara hariombalhara requested review from zomars and a team September 13, 2022 03:56
Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but two things

  1. Tried going to the automation category and got this error
    https://app.birdeatsbug.com/sessions/V01CJrkJKU7Yznylk256OMy0cfuZuuyxboyMLSbforVA
  2. I think "Automation" should be a category here
    image

@hariombalhara
Copy link
Member Author

@joeauyeung It works for me. There is an automation category where you mentioned as shown in the Demo loom

I think it might be because you haven't run migrations?

Copy link
Contributor

@baileypumfleet baileypumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me

@hariombalhara hariombalhara added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Sep 15, 2022
@baileypumfleet baileypumfleet merged commit d3b9ebb into main Sep 15, 2022
@baileypumfleet baileypumfleet deleted the add-automation-category branch September 15, 2022 08:16
@zomars zomars added the ❗️ migrations contains migration files label Sep 15, 2022
@zomars
Copy link
Member

zomars commented Sep 15, 2022

@hariombalhara do we need to update something on the current Zapier entry on our prod DB to prevent breaking?

@hariombalhara
Copy link
Member Author

There are migrations for that.

@CarinaWolli CarinaWolli mentioned this pull request Sep 27, 2022
1 task
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date core area: core, team members only ❗️ migrations contains migration files
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants