Fixes password prompt race condition #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
approved these changes
Sep 21, 2022
| bio: user?.bio || "", | ||
| }, | ||
| }); | ||
| const formMethods = useForm<{ |
There was a problem hiding this comment.
Going forward, suspense mode might be a better approach to avoid unnecessary useEffect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FormMethods is created with default values that can sometimes be "" due to the user not being loaded. Because tests run very fast this can cause the form to be submitted before the default value had a chance to update from the initial draw. When this happens the form value != the email and the password prompt is shown.